[PR #1234] [MERGED] Fix test_https_google #2111

New issue

Closed

opened 2026-03-16 05:49:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:49:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1234
Author: @djc
Created: 10/9/2020
Status: ✅ Merged
Merged: 10/10/2020
Merged by: @bluejekyll

Base: main ← Head: fix-google-test

📝 Commits (2)

7ab6d53 https: enable key logging in Google HTTPS test
4dd36d6 https: retry Google HTTPS test on ServFail response (fixes #1217)

📊 Changes

1 file changed (+23 additions, -16 deletions)

View changed files

📝 crates/https/src/https_client_stream.rs (+23 -16)

📄 Description

Apparently this will sometimes return a ServFail error; if so, just retry the request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1234 **Author:** [@djc](https://github.com/djc) **Created:** 10/9/2020 **Status:** ✅ Merged **Merged:** 10/10/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix-google-test` --- ### 📝 Commits (2) - [`7ab6d53`](https://github.com/hickory-dns/hickory-dns/commit/7ab6d534f26cae468ca4935985d20d85cd0b5f75) https: enable key logging in Google HTTPS test - [`4dd36d6`](https://github.com/hickory-dns/hickory-dns/commit/4dd36d6124f02f8dea33e2d986dd02a5c21d2b47) https: retry Google HTTPS test on ServFail response (fixes #1217) ### 📊 Changes **1 file changed** (+23 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `crates/https/src/https_client_stream.rs` (+23 -16) </details> ### 📄 Description Apparently this will sometimes return a ServFail error; if so, just retry the request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>