[PR #1227] [MERGED] avoid unwrap() for functions that don't error #2106

New issue

Closed

opened 2026-03-16 05:49:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:49:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1227
Author: @djc
Created: 10/5/2020
Status: ✅ Merged
Merged: 10/5/2020
Merged by: @bluejekyll

Base: main ← Head: avoid-unwrap

📝 Commits (1)

2e09a70 avoid unwrap() for functions that don't error

📊 Changes

13 files changed (+17 additions, -17 deletions)

View changed files

📝 crates/proto/src/multicast/mdns_stream.rs (+2 -2)
📝 crates/proto/src/rr/resource.rs (+1 -1)
📝 crates/proto/src/tcp/tcp_stream.rs (+1 -1)
📝 crates/proto/src/xfer/dns_exchange.rs (+2 -2)
📝 crates/proto/src/xfer/dns_handle.rs (+1 -1)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+1 -1)
📝 crates/proto/src/xfer/dns_request.rs (+1 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+2 -2)
📝 crates/proto/src/xfer/mod.rs (+2 -2)
📝 crates/proto/src/xfer/serial_message.rs (+1 -1)
📝 crates/resolver/src/async_resolver.rs (+1 -1)
📝 crates/resolver/src/lookup.rs (+1 -1)
📝 tests/integration-tests/tests/mdns_tests.rs (+1 -1)

📄 Description

into_*() and into_parts() specifically seem more idiomatic for these functions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1227 **Author:** [@djc](https://github.com/djc) **Created:** 10/5/2020 **Status:** ✅ Merged **Merged:** 10/5/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `avoid-unwrap` --- ### 📝 Commits (1) - [`2e09a70`](https://github.com/hickory-dns/hickory-dns/commit/2e09a70f7feebc1dffcb6f880acb95fcfc5947e9) avoid unwrap() for functions that don't error ### 📊 Changes **13 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -2) 📝 `crates/proto/src/rr/resource.rs` (+1 -1) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+2 -2) 📝 `crates/proto/src/xfer/dns_handle.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_request.rs` (+1 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+2 -2) 📝 `crates/proto/src/xfer/mod.rs` (+2 -2) 📝 `crates/proto/src/xfer/serial_message.rs` (+1 -1) 📝 `crates/resolver/src/async_resolver.rs` (+1 -1) 📝 `crates/resolver/src/lookup.rs` (+1 -1) 📝 `tests/integration-tests/tests/mdns_tests.rs` (+1 -1) </details> ### 📄 Description `into_*()` and `into_parts()` specifically seem more idiomatic for these functions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>