[PR #1215] [MERGED] Add built-in configuration for Google over HTTPS #2092

Closed
opened 2026-03-16 05:42:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1215
Author: @djc
Created: 9/25/2020
Status: Merged
Merged: 10/5/2020
Merged by: @bluejekyll

Base: mainHead: google-https


📝 Commits (3)

  • 60519ce move IP addresses for public DNS services into constants
  • 0311b62 fix copy/paste error in cloudflare_https() docstring
  • 08f1def add built-in configuration for Google over HTTPS

📊 Changes

1 file changed (+37 additions, -60 deletions)

View changed files

📝 crates/resolver/src/config.rs (+37 -60)

📄 Description

Possible alternative: instead expose the IP address slices publicly and remove the foo(), foo_tls() and foo_https() wrappers around Self::from_ips_clear(), Self::from_ips_tls() and Self::from_ips_https(), which prevents the combinatorial explosion of providers and protocol options.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1215 **Author:** [@djc](https://github.com/djc) **Created:** 9/25/2020 **Status:** ✅ Merged **Merged:** 10/5/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `google-https` --- ### 📝 Commits (3) - [`60519ce`](https://github.com/hickory-dns/hickory-dns/commit/60519cea7a083cf10fa5fda8b948ae03666e1a01) move IP addresses for public DNS services into constants - [`0311b62`](https://github.com/hickory-dns/hickory-dns/commit/0311b622c0f5702592c6c328ff92b684a6ebde16) fix copy/paste error in cloudflare_https() docstring - [`08f1def`](https://github.com/hickory-dns/hickory-dns/commit/08f1deff5fa9a82178dbf673e476ffa5c6bce2ad) add built-in configuration for Google over HTTPS ### 📊 Changes **1 file changed** (+37 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/config.rs` (+37 -60) </details> ### 📄 Description Possible alternative: instead expose the IP address slices publicly and remove the `foo()`, `foo_tls()` and `foo_https()` wrappers around `Self::from_ips_clear()`, `Self::from_ips_tls()` and `Self::from_ips_https()`, which prevents the combinatorial explosion of providers and protocol options. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 05:42:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2092
No description provided.