[PR #1206] [MERGED] Change the return value for ResponseCode::high from u16 to u8 #2077

New issue

Closed

opened 2026-03-16 05:34:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:34:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1206
Author: @jonasbb
Created: 9/16/2020
Status: ✅ Merged
Merged: 9/16/2020
Merged by: @bluejekyll

Base: main ← Head: responsecode-high

📝 Commits (1)

a2823dc Change the return value for ResponseCode::high from u16 to u8

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 crates/proto/src/op/response_code.rs (+3 -3)

📄 Description

The EDNS response code part only contains 8 bit so the return type fits its
need better. This aligns the type with ResponseCode::from and
Edns::set_rcode_high.

Closes #1202

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1206 **Author:** [@jonasbb](https://github.com/jonasbb) **Created:** 9/16/2020 **Status:** ✅ Merged **Merged:** 9/16/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `responsecode-high` --- ### 📝 Commits (1) - [`a2823dc`](https://github.com/hickory-dns/hickory-dns/commit/a2823dc299ea122b73b549140e71783f039dad47) Change the return value for ResponseCode::high from u16 to u8 ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `crates/proto/src/op/response_code.rs` (+3 -3) </details> ### 📄 Description The EDNS response code part only contains 8 bit so the return type fits its need better. This aligns the type with `ResponseCode::from` and `Edns::set_rcode_high`. Closes #1202 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>