[PR #1197] [MERGED] Generic errors in proto #2073

New issue

Closed

opened 2026-03-16 05:34:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:34:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1197
Author: @bluejekyll
Created: 9/7/2020
Status: ✅ Merged
Merged: 9/15/2020
Merged by: @bluejekyll

Base: main ← Head: generic-errors-in-proto

📝 Commits (4)

48c72a4 make errors generic in DnsHandle for Resolver
f4bb557 more accurate negative responses
6232544 ensure caching of negative responses is correct
65303a1 fix regexes for beta and nightly Rust versions

📊 Changes

31 files changed (+1577 additions, -392 deletions)

View changed files

📝 CHANGELOG.md (+7 -0)
📝 Makefile.toml (+1 -0)
📝 bin/tests/server_harness/mod.rs (+8 -5)
📝 bin/tests/server_harness/mut_message_client.rs (+1 -0)
📝 crates/async-std-resolver/src/runtime.rs (+2 -2)
📝 crates/async-std-resolver/src/tests.rs (+3 -2)
📝 crates/client/src/client/async_client.rs (+3 -2)
📝 crates/client/src/client/async_secure_client.rs (+1 -0)
📝 crates/client/src/client/client.rs (+1 -1)
📝 crates/client/src/client/memoize_client_handle.rs (+2 -0)
📝 crates/proto/src/op/message.rs (+13 -0)
📝 crates/proto/src/rr/record_type.rs (+12 -0)
📝 crates/proto/src/xfer/dns_exchange.rs (+1 -0)
📝 crates/proto/src/xfer/dns_handle.rs (+5 -1)
📝 crates/proto/src/xfer/dns_response.rs (+722 -1)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+51 -37)
📝 crates/proto/src/xfer/mod.rs (+1 -0)
📝 crates/proto/src/xfer/retry_dns_handle.rs (+16 -6)
📝 crates/resolver/src/async_resolver.rs (+8 -6)
📝 crates/resolver/src/dns_lru.rs (+139 -48)

...and 11 more files

📄 Description

This should resolve the issue with the NXDOMAIN detection. We can't do anything with the trustworthiness of the answers from upstream resolvers and authorities, but we can at least surface the correct error.

Fixes: #1171

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1197 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 9/7/2020 **Status:** ✅ Merged **Merged:** 9/15/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `generic-errors-in-proto` --- ### 📝 Commits (4) - [`48c72a4`](https://github.com/hickory-dns/hickory-dns/commit/48c72a489820edd88f6eec8f704aa1682c2563be) make errors generic in DnsHandle for Resolver - [`f4bb557`](https://github.com/hickory-dns/hickory-dns/commit/f4bb5571d9a938988f9dc7b017aa305f0aff471f) more accurate negative responses - [`6232544`](https://github.com/hickory-dns/hickory-dns/commit/62325441bf2ace609027219fc62d06ee2f9120ab) ensure caching of negative responses is correct - [`65303a1`](https://github.com/hickory-dns/hickory-dns/commit/65303a12f64667483434fbd3995b36c7edb7ccbc) fix regexes for beta and nightly Rust versions ### 📊 Changes **31 files changed** (+1577 additions, -392 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -0) 📝 `Makefile.toml` (+1 -0) 📝 `bin/tests/server_harness/mod.rs` (+8 -5) 📝 `bin/tests/server_harness/mut_message_client.rs` (+1 -0) 📝 `crates/async-std-resolver/src/runtime.rs` (+2 -2) 📝 `crates/async-std-resolver/src/tests.rs` (+3 -2) 📝 `crates/client/src/client/async_client.rs` (+3 -2) 📝 `crates/client/src/client/async_secure_client.rs` (+1 -0) 📝 `crates/client/src/client/client.rs` (+1 -1) 📝 `crates/client/src/client/memoize_client_handle.rs` (+2 -0) 📝 `crates/proto/src/op/message.rs` (+13 -0) 📝 `crates/proto/src/rr/record_type.rs` (+12 -0) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+1 -0) 📝 `crates/proto/src/xfer/dns_handle.rs` (+5 -1) 📝 `crates/proto/src/xfer/dns_response.rs` (+722 -1) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+51 -37) 📝 `crates/proto/src/xfer/mod.rs` (+1 -0) 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+16 -6) 📝 `crates/resolver/src/async_resolver.rs` (+8 -6) 📝 `crates/resolver/src/dns_lru.rs` (+139 -48) _...and 11 more files_ </details> ### 📄 Description This should resolve the issue with the `NXDOMAIN` detection. We can't do anything with the trustworthiness of the answers from upstream resolvers and authorities, but we can at least surface the correct error. Fixes: #1171 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>