[PR #1190] [CLOSED] Flat name #2065

New issue

Closed

opened 2026-03-16 05:18:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:18:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1190
Author: @bluejekyll
Created: 8/15/2020
Status: ❌ Closed

Base: main ← Head: flat_name

📝 Commits (10+)

667da5f flatten Name representation
481b5e2 improve to lowercase
7dc7241 complete DnsLabel implementations
1651868 add LabelRef
5b63da9 all proto tests passing with NameRef and CowName
fa69b23 fix name benches
33398bf fix cmp for new Name labels
0a7cdb0 trying simplified NameRef
b054e11 unsafe borrowed name
74bee7d transparent LabelRef

📊 Changes

43 files changed (+2628 additions, -998 deletions)

View changed files

📝 crates/client/src/client/async_client.rs (+1 -0)
📝 crates/client/src/client/client.rs (+3 -3)
📝 crates/client/src/op/update_message.rs (+1 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+5 -1)
📝 crates/client/src/rr/lower_name.rs (+61 -11)
📝 crates/client/src/rr/zone.rs (+81 -83)
📝 crates/client/src/serialize/txt/rdata_parsers/mx.rs (+4 -2)
📝 crates/client/src/serialize/txt/rdata_parsers/name.rs (+2 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/naptr.rs (+3 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/soa.rs (+3 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/srv.rs (+3 -1)
📝 crates/client/src/serialize/txt/zone.rs (+4 -2)
📝 crates/proto/benches/name_benches.rs (+37 -24)
📝 crates/proto/src/lib.rs (+1 -0)
📝 crates/proto/src/op/query.rs (+7 -4)
📝 crates/proto/src/rr/dnssec/nsec3.rs (+4 -2)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+4 -3)
📝 crates/proto/src/rr/dnssec/rdata/sig.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/tbs.rs (+1 -0)
➕ crates/proto/src/rr/domain/cow_name.rs (+189 -0)

...and 23 more files

📄 Description

An attempt at making Name have zero-overhead options.

this currently show a performance degradation over the existing implementation.

Until I can figure out if there's a way around those, I'll be leaving this as a draft for experimentation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1190 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 8/15/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `flat_name` --- ### 📝 Commits (10+) - [`667da5f`](https://github.com/hickory-dns/hickory-dns/commit/667da5f77743fabd6b61461766ea0f3cd9791ca8) flatten Name representation - [`481b5e2`](https://github.com/hickory-dns/hickory-dns/commit/481b5e22491c9ba269101d11ba5f5c921b2ca937) improve to lowercase - [`7dc7241`](https://github.com/hickory-dns/hickory-dns/commit/7dc72411742a3cfcdb046dfee52587b561078706) complete DnsLabel implementations - [`1651868`](https://github.com/hickory-dns/hickory-dns/commit/16518682ff10c95109c8ed7a37b63bf305d570ac) add LabelRef - [`5b63da9`](https://github.com/hickory-dns/hickory-dns/commit/5b63da9df18629612fdb6dfdf4c472c4da0361a7) all proto tests passing with NameRef and CowName - [`fa69b23`](https://github.com/hickory-dns/hickory-dns/commit/fa69b23c829c3a927314eb8c3f14e929aa7e6de7) fix name benches - [`33398bf`](https://github.com/hickory-dns/hickory-dns/commit/33398bf410eaa2170fa7aaa060175aa3a362bc21) fix cmp for new Name labels - [`0a7cdb0`](https://github.com/hickory-dns/hickory-dns/commit/0a7cdb0ef1e9314f4859d61746b937e4e258cecf) trying simplified NameRef - [`b054e11`](https://github.com/hickory-dns/hickory-dns/commit/b054e111e02d8ad193890d41eaa1c17fdc8f0792) unsafe borrowed name - [`74bee7d`](https://github.com/hickory-dns/hickory-dns/commit/74bee7d786ea767a865ba7a03e0045f20f8bc71f) transparent LabelRef ### 📊 Changes **43 files changed** (+2628 additions, -998 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/async_client.rs` (+1 -0) 📝 `crates/client/src/client/client.rs` (+3 -3) 📝 `crates/client/src/op/update_message.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+5 -1) 📝 `crates/client/src/rr/lower_name.rs` (+61 -11) 📝 `crates/client/src/rr/zone.rs` (+81 -83) 📝 `crates/client/src/serialize/txt/rdata_parsers/mx.rs` (+4 -2) 📝 `crates/client/src/serialize/txt/rdata_parsers/name.rs` (+2 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/naptr.rs` (+3 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/soa.rs` (+3 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/srv.rs` (+3 -1) 📝 `crates/client/src/serialize/txt/zone.rs` (+4 -2) 📝 `crates/proto/benches/name_benches.rs` (+37 -24) 📝 `crates/proto/src/lib.rs` (+1 -0) 📝 `crates/proto/src/op/query.rs` (+7 -4) 📝 `crates/proto/src/rr/dnssec/nsec3.rs` (+4 -2) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+4 -3) 📝 `crates/proto/src/rr/dnssec/rdata/sig.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/tbs.rs` (+1 -0) ➕ `crates/proto/src/rr/domain/cow_name.rs` (+189 -0) _...and 23 more files_ </details> ### 📄 Description An attempt at making Name have zero-overhead options. this currently show a performance degradation over the existing implementation. Until I can figure out if there's a way around those, I'll be leaving this as a draft for experimentation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>