[PR #1182] [MERGED] Support pointer ending label compression #2048

New issue

Closed

opened 2026-03-16 05:01:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:01:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1182
Author: @jacoblin1994
Created: 8/6/2020
Status: ✅ Merged
Merged: 8/6/2020
Merged by: @bluejekyll

Base: main ← Head: support-pointer-ending-label-compression

📝 Commits (5)

334a96d Update encoder.rs for proper pointer compression
0d16baa Update name.rs to add more unit tests
0422a16 Update encoder.rs
c96b939 Update encoder.rs for style check
92ae831 Merge branch 'main' into support-pointer-ending-label-compression

📊 Changes

2 files changed (+45 additions, -10 deletions)

View changed files

📝 crates/proto/src/rr/domain/name.rs (+36 -0)
📝 crates/proto/src/serialize/binary/encoder.rs (+9 -10)

📄 Description

Update encoder.rs to support pointer-ending label compression and name.rs to add more unit tests.

I have tested locally on my own software that is based on trust-dns-proto as well as added and passed all unit tests; however, this is my first time working on Github, so I am not familiar with what tools are available to me to run, e.g. possibly built-in style check or master unit tests. I do not know if I can have some sanity tests run on Github. Please advise. Thank you.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1182 **Author:** [@jacoblin1994](https://github.com/jacoblin1994) **Created:** 8/6/2020 **Status:** ✅ Merged **Merged:** 8/6/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `support-pointer-ending-label-compression` --- ### 📝 Commits (5) - [`334a96d`](https://github.com/hickory-dns/hickory-dns/commit/334a96d78f5526ec95718e42a5b038f411d89577) Update encoder.rs for proper pointer compression - [`0d16baa`](https://github.com/hickory-dns/hickory-dns/commit/0d16baa1685fbdeb739dbada2c55915070843da2) Update name.rs to add more unit tests - [`0422a16`](https://github.com/hickory-dns/hickory-dns/commit/0422a16abb6f79b95516883e93ff89a994f0e7a8) Update encoder.rs - [`c96b939`](https://github.com/hickory-dns/hickory-dns/commit/c96b939872a90d72d4597efe5ce1a5c66cbd33e9) Update encoder.rs for style check - [`92ae831`](https://github.com/hickory-dns/hickory-dns/commit/92ae83185114b28e96b22922b7c21dc1f11e25ae) Merge branch 'main' into support-pointer-ending-label-compression ### 📊 Changes **2 files changed** (+45 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/domain/name.rs` (+36 -0) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+9 -10) </details> ### 📄 Description Update encoder.rs to [support pointer-ending label compression](https://github.com/bluejekyll/trust-dns/issues/1179) and name.rs to add more unit tests. I have tested locally on my own software that is based on trust-dns-proto as well as added and passed all unit tests; however, this is my first time working on Github, so I am not familiar with what tools are available to me to run, e.g. possibly built-in style check or master unit tests. I do not know if I can have some sanity tests run on Github. Please advise. Thank you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>