[PR #1123] [MERGED] forwarder: return NXDomain on e.is_nx_domain() #1990

New issue

Closed

opened 2026-03-16 04:20:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:20:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1123
Author: @balboah
Created: 5/26/2020
Status: ✅ Merged
Merged: 6/4/2020
Merged by: @bluejekyll

Base: master ← Head: fix/forwarder

📝 Commits (2)

bea1730 return NXDomain on e.is_nx_domain()
0124e57 Merge branch 'master' into fix/forwarder

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 crates/server/src/authority/catalog.rs (+9 -3)

📄 Description

ZoneType::Forward authority seems to not have gotten much love. This adds NXDomain status on "not found" errors.

We're still missing a SOA record, perhaps this can be picked up on a later refactor to re-use parts of AuthorityLookupState.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1123 **Author:** [@balboah](https://github.com/balboah) **Created:** 5/26/2020 **Status:** ✅ Merged **Merged:** 6/4/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix/forwarder` --- ### 📝 Commits (2) - [`bea1730`](https://github.com/hickory-dns/hickory-dns/commit/bea173041d35e9e24ce3189a30d3ac5e88dc7022) return NXDomain on e.is_nx_domain() - [`0124e57`](https://github.com/hickory-dns/hickory-dns/commit/0124e57e19c038f17214eed9b04db67951c88a32) Merge branch 'master' into fix/forwarder ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/authority/catalog.rs` (+9 -3) </details> ### 📄 Description `ZoneType::Forward` authority seems to not have gotten much love. This adds NXDomain status on "not found" errors. We're still missing a SOA record, perhaps this can be picked up on a later refactor to re-use parts of `AuthorityLookupState`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>