[PR #1109] [MERGED] Minimize `futures` dependencies #1973

New issue

Closed

opened 2026-03-16 04:19:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:19:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1109
Author: @JohnTitor
Created: 5/18/2020
Status: ✅ Merged
Merged: 5/19/2020
Merged by: @bluejekyll

Base: master ← Head: minimize-futures

📝 Commits (3)

119b966 proto: Minimize futures dependencies
a2737cb resolver: Minimize futures dependencies
5fb5171 Merge branch 'master' into minimize-futures

📊 Changes

34 files changed (+84 additions, -77 deletions)

View changed files

📝 Cargo.lock (+6 -2)
📝 crates/proto/Cargo.toml (+4 -2)
📝 crates/proto/src/error.rs (+1 -1)
📝 crates/proto/src/lib.rs (+2 -2)
📝 crates/proto/src/multicast/mdns_client_stream.rs (+2 -2)
📝 crates/proto/src/multicast/mdns_stream.rs (+5 -7)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+2 -2)
📝 crates/proto/src/tcp/tcp_stream.rs (+7 -6)
📝 crates/proto/src/tests/tcp.rs (+2 -2)
📝 crates/proto/src/tests/udp.rs (+2 -2)
📝 crates/proto/src/udp/udp_client_stream.rs (+2 -2)
📝 crates/proto/src/udp/udp_stream.rs (+3 -3)
📝 crates/proto/src/xfer/dns_exchange.rs (+3 -3)
📝 crates/proto/src/xfer/dns_handle.rs (+2 -2)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+3 -3)
📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+2 -2)
📝 crates/proto/src/xfer/mod.rs (+5 -3)
📝 crates/proto/src/xfer/retry_dns_handle.rs (+3 -3)
📝 crates/resolver/Cargo.toml (+2 -2)
📝 crates/resolver/examples/global_resolver.rs (+2 -2)

...and 14 more files

📄 Description

This helps us reducing futures-related dependencies. We use proto and resolver so I touched them only but I'm happy to do the same work for other crates if you like.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1109 **Author:** [@JohnTitor](https://github.com/JohnTitor) **Created:** 5/18/2020 **Status:** ✅ Merged **Merged:** 5/19/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `minimize-futures` --- ### 📝 Commits (3) - [`119b966`](https://github.com/hickory-dns/hickory-dns/commit/119b9669c0e3097daeb955e221bf8dd68b32965b) proto: Minimize `futures` dependencies - [`a2737cb`](https://github.com/hickory-dns/hickory-dns/commit/a2737cb8d431485cb3343d6df38a87b7b3788451) resolver: Minimize `futures` dependencies - [`5fb5171`](https://github.com/hickory-dns/hickory-dns/commit/5fb51715282f8579e440ed8ee8c964d9bd0d0816) Merge branch 'master' into minimize-futures ### 📊 Changes **34 files changed** (+84 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+6 -2) 📝 `crates/proto/Cargo.toml` (+4 -2) 📝 `crates/proto/src/error.rs` (+1 -1) 📝 `crates/proto/src/lib.rs` (+2 -2) 📝 `crates/proto/src/multicast/mdns_client_stream.rs` (+2 -2) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+5 -7) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+2 -2) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+7 -6) 📝 `crates/proto/src/tests/tcp.rs` (+2 -2) 📝 `crates/proto/src/tests/udp.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_stream.rs` (+3 -3) 📝 `crates/proto/src/xfer/dns_exchange.rs` (+3 -3) 📝 `crates/proto/src/xfer/dns_handle.rs` (+2 -2) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+3 -3) 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+2 -2) 📝 `crates/proto/src/xfer/mod.rs` (+5 -3) 📝 `crates/proto/src/xfer/retry_dns_handle.rs` (+3 -3) 📝 `crates/resolver/Cargo.toml` (+2 -2) 📝 `crates/resolver/examples/global_resolver.rs` (+2 -2) _...and 14 more files_ </details> ### 📄 Description This helps us reducing futures-related dependencies. We use proto and resolver so I touched them only but I'm happy to do the same work for other crates if you like. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>