[PR #1095] [MERGED] resolver: use IntoName trait on synchronous resolver interface #1965

New issue

Closed

opened 2026-03-16 04:17:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:17:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1095
Author: @krisztian-kovacs
Created: 5/5/2020
Status: ✅ Merged
Merged: 5/6/2020
Merged by: @bluejekyll

Base: master ← Head: sync-resolver-use-intoname

📝 Commits (2)

d15a585 resolver: use IntoName trait on synchronous resolver interface
f2cd6eb Merge branch 'master' into sync-resolver-use-intoname

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 crates/resolver/src/resolver.rs (+5 -3)

📄 Description

This change modifies the lookup methods of Resolver to accept any type
implementing the IntoName trait instead of just accepting &str.

This is beneficial because this way Resolver users can pass an already parsed
Name so that they have more control over how validation is done (for example,
the string can be parsed using Name::from_ascii()).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1095 **Author:** [@krisztian-kovacs](https://github.com/krisztian-kovacs) **Created:** 5/5/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `sync-resolver-use-intoname` --- ### 📝 Commits (2) - [`d15a585`](https://github.com/hickory-dns/hickory-dns/commit/d15a585e25db52fb241530fe16a295bdcaaab852) resolver: use IntoName trait on synchronous resolver interface - [`f2cd6eb`](https://github.com/hickory-dns/hickory-dns/commit/f2cd6eb7933643e58097c268244e04a128daf061) Merge branch 'master' into sync-resolver-use-intoname ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/resolver.rs` (+5 -3) </details> ### 📄 Description This change modifies the lookup methods of Resolver to accept any type implementing the IntoName trait instead of just accepting &str. This is beneficial because this way Resolver users can pass an already parsed Name so that they have more control over how validation is done (for example, the string can be parsed using Name::from_ascii()). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>