[PR #1033] [MERGED] Balboah fix/missing cname records #1894

New issue

Closed

opened 2026-03-16 03:10:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 03:10:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1033
Author: @bluejekyll
Created: 2/27/2020
Status: ✅ Merged
Merged: 2/28/2020
Merged by: @bluejekyll

Base: master ← Head: balboah-fix/missing_cname_records

📝 Commits (7)

5ba56d7 Allow CNAME records on A/AAAA lookups
c361fc8 rustfmt
e2f0416 Fix cname chain min TTL test
c2bedab Fix lookup integration tests & max query depth
46d8721 add preserve_intermediates option
39c86ac preserve records across queries
10992a7 add as_lookup to LookupIp

📊 Changes

7 files changed (+239 additions, -109 deletions)

View changed files

📝 .rustfmt.toml (+1 -0)
📝 crates/resolver/src/async_resolver.rs (+1 -1)
📝 crates/resolver/src/config.rs (+3 -0)
📝 crates/resolver/src/lookup.rs (+18 -4)
📝 crates/resolver/src/lookup_ip.rs (+20 -13)
📝 crates/resolver/src/lookup_state.rs (+109 -82)
📝 tests/integration-tests/tests/lookup_tests.rs (+87 -9)

📄 Description

fyi @balboah I think this fully supercedes #1028

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1033 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/27/2020 **Status:** ✅ Merged **Merged:** 2/28/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `balboah-fix/missing_cname_records` --- ### 📝 Commits (7) - [`5ba56d7`](https://github.com/hickory-dns/hickory-dns/commit/5ba56d791a68b06fd4f8fb2141b5bc11ad5d41eb) Allow CNAME records on A/AAAA lookups - [`c361fc8`](https://github.com/hickory-dns/hickory-dns/commit/c361fc8d3cdee65036ec70ddb2676b9fc02d0172) rustfmt - [`e2f0416`](https://github.com/hickory-dns/hickory-dns/commit/e2f04164554a4bc08b0225ee841dee57d49bb403) Fix cname chain min TTL test - [`c2bedab`](https://github.com/hickory-dns/hickory-dns/commit/c2bedab45bf8d9720cdb0394c35975ad26d343f6) Fix lookup integration tests & max query depth - [`46d8721`](https://github.com/hickory-dns/hickory-dns/commit/46d8721f5ac30245f3afb9eceaa276e542f7d292) add preserve_intermediates option - [`39c86ac`](https://github.com/hickory-dns/hickory-dns/commit/39c86ac13106c2ad53da0a8ce07fbc99b0840057) preserve records across queries - [`10992a7`](https://github.com/hickory-dns/hickory-dns/commit/10992a7dd7c4a2255055154763440fa7e465e343) add as_lookup to LookupIp ### 📊 Changes **7 files changed** (+239 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `.rustfmt.toml` (+1 -0) 📝 `crates/resolver/src/async_resolver.rs` (+1 -1) 📝 `crates/resolver/src/config.rs` (+3 -0) 📝 `crates/resolver/src/lookup.rs` (+18 -4) 📝 `crates/resolver/src/lookup_ip.rs` (+20 -13) 📝 `crates/resolver/src/lookup_state.rs` (+109 -82) 📝 `tests/integration-tests/tests/lookup_tests.rs` (+87 -9) </details> ### 📄 Description fyi @balboah I think this fully supercedes #1028 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>