[PR #1026] [MERGED] Cleanup unimplemented for RData parser #1890

New issue

Closed

opened 2026-03-16 03:10:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 03:10:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1026
Author: @kachayev
Created: 2/16/2020
Status: ✅ Merged
Merged: 2/18/2020
Merged by: @bluejekyll

Base: master ← Head: fix-cleanup-unimplemented

📝 Commits (4)

bb0e3e5 NULL record parser now returns ParseError instaead of unimplemented!
b849f15 Remove redundant clippy:unimplemented
b2cb1a4 Remove redundant clippy:unimplemented
0132601 fix cargo fmt

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 crates/client/src/serialize/txt/rdata_parsers/null.rs (+3 -2)
📝 crates/server/src/store/forwarder/authority.rs (+0 -1)

📄 Description

This PR partially covers #917 except unimplemented $INCLUDE from master files. Seems like it would be valueable to have $INCLUDE implemented not just wrapped into Error, right?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1026 **Author:** [@kachayev](https://github.com/kachayev) **Created:** 2/16/2020 **Status:** ✅ Merged **Merged:** 2/18/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-cleanup-unimplemented` --- ### 📝 Commits (4) - [`bb0e3e5`](https://github.com/hickory-dns/hickory-dns/commit/bb0e3e52007ed0e4b1260b24deff2d789d023373) NULL record parser now returns ParseError instaead of unimplemented! - [`b849f15`](https://github.com/hickory-dns/hickory-dns/commit/b849f1580ea474cdaf75450531f797ccc80a3cec) Remove redundant clippy:unimplemented - [`b2cb1a4`](https://github.com/hickory-dns/hickory-dns/commit/b2cb1a4deebfbbdab1d94cd8ae73f303c127ab45) Remove redundant clippy:unimplemented - [`0132601`](https://github.com/hickory-dns/hickory-dns/commit/013260152e59d2dc22364a16ae9c762828c3acd0) fix cargo fmt ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/rdata_parsers/null.rs` (+3 -2) 📝 `crates/server/src/store/forwarder/authority.rs` (+0 -1) </details> ### 📄 Description This PR partially covers #917 except unimplemented `$INCLUDE` from master files. Seems like it would be valueable to have $INCLUDE implemented not just wrapped into Error, right? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>