[PR #987] [MERGED] Mark socket2 as optional, it does not work on the wasm32-unknown-unknown platform. #1839

New issue

Closed

opened 2026-03-16 02:28:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:28:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/987
Author: @moshevds
Created: 1/11/2020
Status: ✅ Merged
Merged: 1/12/2020
Merged by: @bluejekyll

Base: master ← Head: socket2-optional

📝 Commits (1)

e2a05c3 Mark socket2 as optional, it does not work on the wasm32-unknown-unknown platform.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 crates/proto/Cargo.toml (+1 -1)

📄 Description

I want to use trust-dns as an in-browser DNS client (using a dns-over-https resolver).
This will eventually require trust-dns to export some kind of API that is not considered unstable, but by marking socket2 as optional, it is possible to experiment with this (I have a working proof of concept).

I have not noticed any problem with this change for running the tests, but did not look into it beyond that. Are there any problems that could be expected from this change?

I might also open an issue to discuss the way towards the in-browser client. Either by exposing a stable crate that such a client can depend on, or for implementing such a client as a part this project.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/987 **Author:** [@moshevds](https://github.com/moshevds) **Created:** 1/11/2020 **Status:** ✅ Merged **Merged:** 1/12/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `socket2-optional` --- ### 📝 Commits (1) - [`e2a05c3`](https://github.com/hickory-dns/hickory-dns/commit/e2a05c3727ad6afc3a7e389599369fe3817e7042) Mark socket2 as optional, it does not work on the wasm32-unknown-unknown platform. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/Cargo.toml` (+1 -1) </details> ### 📄 Description I want to use trust-dns as an in-browser DNS client (using a dns-over-https resolver). This will eventually require trust-dns to export some kind of API that is not considered unstable, but by marking socket2 as optional, it is possible to experiment with this (I have a working proof of concept). I have not noticed any problem with this change for running the tests, but did not look into it beyond that. Are there any problems that could be expected from this change? I might also open an issue to discuss the way towards the in-browser client. Either by exposing a stable crate that such a client can depend on, or for implementing such a client as a part this project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>