[PR #979] [MERGED] [trust-dns-resolver] refactor unit tests #1834

New issue

Closed

opened 2026-03-16 02:28:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:28:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/979
Author: @chunyingw
Created: 12/30/2019
Status: ✅ Merged
Merged: 1/2/2020
Merged by: @bluejekyll

Base: master ← Head: refactor

📝 Commits (2)

f83235d [trust-dns-resolver] refactor tests
1b51e9c [trust-dns-resolver] refactor tests

📊 Changes

5 files changed (+444 additions, -242 deletions)

View changed files

📝 crates/proto/src/lib.rs (+7 -1)
📝 crates/resolver/Cargo.toml (+1 -0)
📝 crates/resolver/src/async_resolver.rs (+431 -240)
📝 crates/resolver/src/lib.rs (+2 -0)
📝 crates/resolver/src/name_server/mod.rs (+3 -1)

📄 Description

This allows the unit tests defined in the async_resolver mod to run with different runtime. In my use case, Fuchsia does not need to reinvent the wheel or duplicate the test cases defined in trust-dns-resolver.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/979 **Author:** [@chunyingw](https://github.com/chunyingw) **Created:** 12/30/2019 **Status:** ✅ Merged **Merged:** 1/2/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `refactor` --- ### 📝 Commits (2) - [`f83235d`](https://github.com/hickory-dns/hickory-dns/commit/f83235d4915b1d1f9ae4a7bb0df1dea3ca1610ef) [trust-dns-resolver] refactor tests - [`1b51e9c`](https://github.com/hickory-dns/hickory-dns/commit/1b51e9c8e227613d747d9e9ddcad2a7bb53de404) [trust-dns-resolver] refactor tests ### 📊 Changes **5 files changed** (+444 additions, -242 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/lib.rs` (+7 -1) 📝 `crates/resolver/Cargo.toml` (+1 -0) 📝 `crates/resolver/src/async_resolver.rs` (+431 -240) 📝 `crates/resolver/src/lib.rs` (+2 -0) 📝 `crates/resolver/src/name_server/mod.rs` (+3 -1) </details> ### 📄 Description This allows the unit tests defined in the async_resolver mod to run with different runtime. In my use case, Fuchsia does not need to reinvent the wheel or duplicate the test cases defined in trust-dns-resolver. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>