[PR #975] [MERGED] [trust-dns-resolver] Abstract resolver #1833

New issue

Closed

opened 2026-03-16 02:28:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:28:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/975
Author: @chunyingw
Created: 12/28/2019
Status: ✅ Merged
Merged: 12/28/2019
Merged by: @bluejekyll

Base: master ← Head: resolver

📝 Commits (2)

f55ceab [trust-dns-resolver] Abstract resolver
7c3ce43 [trust-dns-resolver] Abstract resolver

📊 Changes

13 files changed (+202 additions, -113 deletions)

View changed files

📝 crates/resolver/Cargo.toml (+1 -1)
📝 crates/resolver/examples/global_resolver.rs (+1 -0)
📝 crates/resolver/examples/multithreaded_runtime.rs (+3 -2)
📝 crates/resolver/src/async_resolver.rs (+33 -29)
📝 crates/resolver/src/dns_sd.rs (+2 -1)
📝 crates/resolver/src/https.rs (+2 -2)
📝 crates/resolver/src/lib.rs (+3 -2)
📝 crates/resolver/src/name_server/connection_provider.rs (+144 -67)
📝 crates/resolver/src/name_server/mod.rs (+5 -3)
📝 crates/resolver/src/name_server/name_server.rs (+1 -0)
📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -0)
📝 crates/resolver/src/tls/mod.rs (+2 -2)
📝 crates/server/src/store/forwarder/authority.rs (+4 -4)

📄 Description

Create a trait RuntimeProvider to abstract the resolver
implementation.
Make TokioAsyncResolver as default type.
Keep the tls related codes unchanged, which may be abstracted at a
later point.
Update the other codes and test cases wherever necessary.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/975 **Author:** [@chunyingw](https://github.com/chunyingw) **Created:** 12/28/2019 **Status:** ✅ Merged **Merged:** 12/28/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `resolver` --- ### 📝 Commits (2) - [`f55ceab`](https://github.com/hickory-dns/hickory-dns/commit/f55ceabfd1880809b02f84f43e2a245131689dff) [trust-dns-resolver] Abstract resolver - [`7c3ce43`](https://github.com/hickory-dns/hickory-dns/commit/7c3ce430ae0800cc82c44df5781ebe4278b83966) [trust-dns-resolver] Abstract resolver ### 📊 Changes **13 files changed** (+202 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/Cargo.toml` (+1 -1) 📝 `crates/resolver/examples/global_resolver.rs` (+1 -0) 📝 `crates/resolver/examples/multithreaded_runtime.rs` (+3 -2) 📝 `crates/resolver/src/async_resolver.rs` (+33 -29) 📝 `crates/resolver/src/dns_sd.rs` (+2 -1) 📝 `crates/resolver/src/https.rs` (+2 -2) 📝 `crates/resolver/src/lib.rs` (+3 -2) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+144 -67) 📝 `crates/resolver/src/name_server/mod.rs` (+5 -3) 📝 `crates/resolver/src/name_server/name_server.rs` (+1 -0) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -0) 📝 `crates/resolver/src/tls/mod.rs` (+2 -2) 📝 `crates/server/src/store/forwarder/authority.rs` (+4 -4) </details> ### 📄 Description 1. Create a trait RuntimeProvider to abstract the resolver implementation. 2. Make TokioAsyncResolver as default type. 3. Keep the tls related codes unchanged, which may be abstracted at a later point. 4. Update the other codes and test cases wherever necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>