[PR #959] [MERGED] use cargo-with for test coverage #1825

New issue

Closed

opened 2026-03-16 02:27:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:27:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/959
Author: @bluejekyll
Created: 12/17/2019
Status: ✅ Merged
Merged: 12/19/2019
Merged by: @bluejekyll

Base: master ← Head: use-cargo-with-for-coverage

📝 Commits (7)

ab83460 use cargo-with for test coverage
cf05941 cargo-with multi-exec
3b6b50e make output for coverage unique to current crate
b40a226 place coverage data in separate test target dirs
2128f80 allow any 0.4 version of log
1b9b43d run kcov through a script, create distinct target coverage dirs
4812625 fix tokio deprecation

📊 Changes

18 files changed (+194 additions, -142 deletions)

View changed files

📝 .github/workflows/test.yml (+2 -2)
📝 Cargo.lock (+40 -39)
📝 Makefile.toml (+113 -74)
📝 bin/Cargo.toml (+1 -1)
📝 bin/Makefile.toml (+1 -0)
📝 bin/src/named.rs (+1 -1)
📝 crates/client/Cargo.toml (+1 -1)
📝 crates/proto/Cargo.toml (+1 -1)
📝 crates/proto/src/lib.rs (+2 -2)
📝 crates/proto/src/udp/udp_stream.rs (+6 -13)
📝 crates/resolver/Cargo.toml (+1 -1)
📝 crates/resolver/src/async_resolver.rs (+1 -3)
📝 crates/rustls/Cargo.toml (+1 -1)
📝 crates/server/Cargo.toml (+1 -1)
➕ scripts/kcov.sh (+19 -0)
📝 tests/integration-tests/Cargo.toml (+1 -1)
📝 util/Cargo.toml (+1 -1)
📝 util/Makefile.toml (+1 -0)

📄 Description

fixes: #965

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/959 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 12/17/2019 **Status:** ✅ Merged **Merged:** 12/19/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `use-cargo-with-for-coverage` --- ### 📝 Commits (7) - [`ab83460`](https://github.com/hickory-dns/hickory-dns/commit/ab834608ad1f053a7857071c30cd35c002576cb1) use cargo-with for test coverage - [`cf05941`](https://github.com/hickory-dns/hickory-dns/commit/cf05941f66dd41532445bf1b780e768aa4b0e9e6) cargo-with multi-exec - [`3b6b50e`](https://github.com/hickory-dns/hickory-dns/commit/3b6b50e99fbe7503e0248deb74bf4664b381923f) make output for coverage unique to current crate - [`b40a226`](https://github.com/hickory-dns/hickory-dns/commit/b40a226182849fda002e5b8145f6cdec73116bc3) place coverage data in separate test target dirs - [`2128f80`](https://github.com/hickory-dns/hickory-dns/commit/2128f8092e4c4db1aa14a0904b2804bf3cfd0083) allow any 0.4 version of log - [`1b9b43d`](https://github.com/hickory-dns/hickory-dns/commit/1b9b43dada2620f100059f00c270b700c8cf5078) run kcov through a script, create distinct target coverage dirs - [`4812625`](https://github.com/hickory-dns/hickory-dns/commit/481262527bb197e38d494fd7c33fa528b8221f77) fix tokio deprecation ### 📊 Changes **18 files changed** (+194 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+2 -2) 📝 `Cargo.lock` (+40 -39) 📝 `Makefile.toml` (+113 -74) 📝 `bin/Cargo.toml` (+1 -1) 📝 `bin/Makefile.toml` (+1 -0) 📝 `bin/src/named.rs` (+1 -1) 📝 `crates/client/Cargo.toml` (+1 -1) 📝 `crates/proto/Cargo.toml` (+1 -1) 📝 `crates/proto/src/lib.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_stream.rs` (+6 -13) 📝 `crates/resolver/Cargo.toml` (+1 -1) 📝 `crates/resolver/src/async_resolver.rs` (+1 -3) 📝 `crates/rustls/Cargo.toml` (+1 -1) 📝 `crates/server/Cargo.toml` (+1 -1) ➕ `scripts/kcov.sh` (+19 -0) 📝 `tests/integration-tests/Cargo.toml` (+1 -1) 📝 `util/Cargo.toml` (+1 -1) 📝 `util/Makefile.toml` (+1 -0) </details> ### 📄 Description fixes: #965 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>