[PR #935] [MERGED] Background with generic spawn #1801

New issue

Closed

opened 2026-03-16 02:26:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:26:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/935
Author: @bluejekyll
Created: 12/1/2019
Status: ✅ Merged
Merged: 12/12/2019
Merged by: @bluejekyll

Base: master ← Head: background-without-spawn

📝 Commits (10+)

f11a9b7 Squashed commit of the following:
5dd9446 rebased onto tokio 0.2
8a29718 remove Clone and Option from background connects
6c708cc SpawnBg now returns proper future from both impls
cf2f5c4 cleanup from review
9aa8540 fix clippy warnings
e476cc6 remove SpawnBg, spawn in ConnectionProvider
f06be27 fix no-default-features test
b05ba71 Merge remote-tracking branch 'origin/master' into background-without-spawn
f1cc940 only expose testing functions during testing

📊 Changes

66 files changed (+1997 additions, -1900 deletions)

View changed files

📝 CHANGELOG.md (+19 -1)
📝 Cargo.lock (+25 -21)
📝 README.md (+4 -4)
📝 bin/Cargo.toml (+1 -0)
📝 bin/benches/comparison_benches.rs (+19 -13)
📝 bin/src/named.rs (+9 -4)
📝 bin/tests/named_https_tests.rs (+4 -2)
📝 bin/tests/named_openssl_tests.rs (+6 -5)
📝 bin/tests/named_rustls_tests.rs (+8 -4)
📝 bin/tests/named_test_rsa_dnssec.rs (+19 -20)
📝 bin/tests/named_tests.rs (+52 -42)
📝 bin/tests/server_harness/mod.rs (+15 -13)
📝 crates/client/src/client/async_client.rs (+76 -107)
➕ crates/client/src/client/async_secure_client.rs (+168 -0)
📝 crates/client/src/client/client.rs (+103 -141)
📝 crates/client/src/client/client_connection.rs (+1 -1)
📝 crates/client/src/client/mod.rs (+13 -22)
📝 crates/client/src/client/rc_future.rs (+17 -21)
📝 crates/client/src/lib.rs (+9 -14)
📝 crates/client/src/op/update_message.rs (+1 -1)

...and 46 more files

📄 Description

@hawkw this brings the Background back. But I'm still working through how to expose it properly at the NameServer level. I'll leave a note in that location.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/935 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 12/1/2019 **Status:** ✅ Merged **Merged:** 12/12/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `background-without-spawn` --- ### 📝 Commits (10+) - [`f11a9b7`](https://github.com/hickory-dns/hickory-dns/commit/f11a9b7d38b58efeb63676aa98738b733ea652f9) Squashed commit of the following: - [`5dd9446`](https://github.com/hickory-dns/hickory-dns/commit/5dd94466b944bd426d3a91db85315a634438125c) rebased onto tokio 0.2 - [`8a29718`](https://github.com/hickory-dns/hickory-dns/commit/8a29718ade8cf4bc26215e494ac5a6a882226377) remove Clone and Option from background connects - [`6c708cc`](https://github.com/hickory-dns/hickory-dns/commit/6c708cc8d0c17431073b1037537ab3ecd5ae646f) SpawnBg now returns proper future from both impls - [`cf2f5c4`](https://github.com/hickory-dns/hickory-dns/commit/cf2f5c432c756d1990202819510b85cc0caebae0) cleanup from review - [`9aa8540`](https://github.com/hickory-dns/hickory-dns/commit/9aa8540a76e55248d9bbdffd6469f20f1b1242d4) fix clippy warnings - [`e476cc6`](https://github.com/hickory-dns/hickory-dns/commit/e476cc6e07d2f45ef17785f58b58d464b6c68f49) remove SpawnBg, spawn in ConnectionProvider - [`f06be27`](https://github.com/hickory-dns/hickory-dns/commit/f06be271567f7139dcb60ea132f5adfbff3c3a88) fix no-default-features test - [`b05ba71`](https://github.com/hickory-dns/hickory-dns/commit/b05ba7103fef0acca7e8e4c26b7869203c2356e0) Merge remote-tracking branch 'origin/master' into background-without-spawn - [`f1cc940`](https://github.com/hickory-dns/hickory-dns/commit/f1cc94041b2b9ea527c85d4a2f59b7ad029daca3) only expose testing functions during testing ### 📊 Changes **66 files changed** (+1997 additions, -1900 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+19 -1) 📝 `Cargo.lock` (+25 -21) 📝 `README.md` (+4 -4) 📝 `bin/Cargo.toml` (+1 -0) 📝 `bin/benches/comparison_benches.rs` (+19 -13) 📝 `bin/src/named.rs` (+9 -4) 📝 `bin/tests/named_https_tests.rs` (+4 -2) 📝 `bin/tests/named_openssl_tests.rs` (+6 -5) 📝 `bin/tests/named_rustls_tests.rs` (+8 -4) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+19 -20) 📝 `bin/tests/named_tests.rs` (+52 -42) 📝 `bin/tests/server_harness/mod.rs` (+15 -13) 📝 `crates/client/src/client/async_client.rs` (+76 -107) ➕ `crates/client/src/client/async_secure_client.rs` (+168 -0) 📝 `crates/client/src/client/client.rs` (+103 -141) 📝 `crates/client/src/client/client_connection.rs` (+1 -1) 📝 `crates/client/src/client/mod.rs` (+13 -22) 📝 `crates/client/src/client/rc_future.rs` (+17 -21) 📝 `crates/client/src/lib.rs` (+9 -14) 📝 `crates/client/src/op/update_message.rs` (+1 -1) _...and 46 more files_ </details> ### 📄 Description @hawkw this brings the Background back. But I'm still working through how to expose it properly at the NameServer level. I'll leave a note in that location. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>