[PR #923] [MERGED] lock prevent the resolver to do concurrent requests #1795

New issue

Closed

opened 2026-03-16 02:25:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:25:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/923
Author: @ntrippar
Created: 11/15/2019
Status: ✅ Merged
Merged: 11/16/2019
Merged by: @bluejekyll

Base: master ← Head: concurrencylock

📝 Commits (2)

431d0d4 lock prevent the nameserver to do concurrent request
4eba9b2 Fix minor formatting error

📊 Changes

1 file changed (+15 additions, -12 deletions)

View changed files

📝 crates/resolver/src/name_server/name_server_pool.rs (+15 -12)

📄 Description

the lock on conns was preventing to make concurrent requests, in this fix i added the lock inside a scope so as soon the scope is done the conn will be dropped and the mutex will be unlocked.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/923 **Author:** [@ntrippar](https://github.com/ntrippar) **Created:** 11/15/2019 **Status:** ✅ Merged **Merged:** 11/16/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `concurrencylock` --- ### 📝 Commits (2) - [`431d0d4`](https://github.com/hickory-dns/hickory-dns/commit/431d0d44a3247e53fbcf3be7df43d92ed8dfd3c6) lock prevent the nameserver to do concurrent request - [`4eba9b2`](https://github.com/hickory-dns/hickory-dns/commit/4eba9b2813c261b42fd9e0f177d357ebe4a6b027) Fix minor formatting error ### 📊 Changes **1 file changed** (+15 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+15 -12) </details> ### 📄 Description the lock on conns was preventing to make concurrent requests, in this fix i added the lock inside a scope so as soon the scope is done the conn will be dropped and the mutex will be unlocked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>