[PR #918] [MERGED] enforce better code hygiene irt debug statements #1787

Closed
opened 2026-03-16 02:25:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/918
Author: @bluejekyll
Created: 11/10/2019
Status: Merged
Merged: 11/11/2019
Merged by: @bluejekyll

Base: masterHead: clippy-for-debug-statements


📝 Commits (1)

  • 0077caa enforce better code hygiene irt debug statements

📊 Changes

51 files changed (+614 additions, -419 deletions)

View changed files

📝 bin/src/named.rs (+2 -0)
📝 crates/client/src/client/memoize_client_handle.rs (+2 -0)
📝 crates/client/src/lib.rs (+8 -4)
📝 crates/client/src/rr/dnssec/key_format.rs (+2 -0)
📝 crates/client/src/rr/dnssec/signer.rs (+2 -0)
📝 crates/client/src/serialize/txt/master.rs (+3 -2)
📝 crates/client/src/serialize/txt/rdata_parsers/null.rs (+1 -0)
📝 crates/https/src/lib.rs (+6 -1)
📝 crates/native-tls/src/lib.rs (+6 -2)
📝 crates/native-tls/src/tests.rs (+2 -0)
📝 crates/openssl/src/lib.rs (+7 -0)
📝 crates/openssl/src/tls_server.rs (+2 -0)
📝 crates/proto/src/lib.rs (+6 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+2 -0)
📝 crates/proto/src/op/response_code.rs (+1 -0)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+2 -0)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+42 -35)
📝 crates/proto/src/rr/dnssec/rdata/key.rs (+34 -27)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+34 -27)
📝 crates/proto/src/rr/dnssec/rdata/nsec3.rs (+81 -74)

...and 31 more files

📄 Description

fixes: #915

should help prevent issues like #914


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/918 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/10/2019 **Status:** ✅ Merged **Merged:** 11/11/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `clippy-for-debug-statements` --- ### 📝 Commits (1) - [`0077caa`](https://github.com/hickory-dns/hickory-dns/commit/0077caa504fad3f595d8c052fc3464612d1fb6f7) enforce better code hygiene irt debug statements ### 📊 Changes **51 files changed** (+614 additions, -419 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/named.rs` (+2 -0) 📝 `crates/client/src/client/memoize_client_handle.rs` (+2 -0) 📝 `crates/client/src/lib.rs` (+8 -4) 📝 `crates/client/src/rr/dnssec/key_format.rs` (+2 -0) 📝 `crates/client/src/rr/dnssec/signer.rs` (+2 -0) 📝 `crates/client/src/serialize/txt/master.rs` (+3 -2) 📝 `crates/client/src/serialize/txt/rdata_parsers/null.rs` (+1 -0) 📝 `crates/https/src/lib.rs` (+6 -1) 📝 `crates/native-tls/src/lib.rs` (+6 -2) 📝 `crates/native-tls/src/tests.rs` (+2 -0) 📝 `crates/openssl/src/lib.rs` (+7 -0) 📝 `crates/openssl/src/tls_server.rs` (+2 -0) 📝 `crates/proto/src/lib.rs` (+6 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -0) 📝 `crates/proto/src/op/response_code.rs` (+1 -0) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+2 -0) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+42 -35) 📝 `crates/proto/src/rr/dnssec/rdata/key.rs` (+34 -27) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+34 -27) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3.rs` (+81 -74) _...and 31 more files_ </details> ### 📄 Description fixes: #915 should help prevent issues like #914 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 02:25:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1787
No description provided.