[PR #903] [MERGED] Cleanup unnecessary Pin<Box<Future>> where possible #1784

Closed
opened 2026-03-16 02:25:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/903
Author: @bluejekyll
Created: 10/27/2019
Status: Merged
Merged: 11/4/2019
Merged by: @bluejekyll

Base: masterHead: clean-up-pin-boxen


📝 Commits (4)

  • e0ed83b Remove unnecessary Pin<Box<...>> in return positions
  • fcbc809 fixup clippy runs
  • 5b4a1dd update readme for Trust-DNS binaries
  • 197aea2 fix feature compatibility

📊 Changes

41 files changed (+360 additions, -422 deletions)

View changed files

📝 README.md (+3 -1)
📝 bin/tests/named_rustls_tests.rs (+1 -1)
📝 bin/tests/server_harness/mod.rs (+1 -1)
📝 crates/client/src/client/client_future.rs (+1 -1)
📝 crates/client/src/lib.rs (+3 -0)
📝 crates/client/src/rr/dnssec/signer.rs (+3 -3)
📝 crates/https/src/https_server.rs (+3 -43)
📝 crates/https/src/response.rs (+1 -1)
📝 crates/native-tls/src/tests.rs (+1 -1)
📝 crates/openssl/tests/openssl_tests.rs (+1 -1)
📝 crates/proto/src/rr/rr_set.rs (+9 -9)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+1 -1)
📝 crates/proto/src/tcp/tcp_stream.rs (+1 -1)
📝 crates/proto/src/udp/udp_client_stream.rs (+2 -2)
📝 crates/proto/src/udp/udp_stream.rs (+1 -1)
📝 crates/proto/src/xfer/secure_dns_handle.rs (+114 -152)
📝 crates/resolver/src/async_resolver/background.rs (+2 -2)
📝 crates/resolver/src/dns_lru.rs (+10 -10)
📝 crates/resolver/src/hosts.rs (+5 -5)
📝 crates/resolver/src/lib.rs (+2 -0)

...and 21 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/903 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/27/2019 **Status:** ✅ Merged **Merged:** 11/4/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `clean-up-pin-boxen` --- ### 📝 Commits (4) - [`e0ed83b`](https://github.com/hickory-dns/hickory-dns/commit/e0ed83b2021a1959bff62aef01f67237353596ca) Remove unnecessary Pin<Box<...>> in return positions - [`fcbc809`](https://github.com/hickory-dns/hickory-dns/commit/fcbc809adb66b0439d324bf45cc4cb8d4778dfd4) fixup clippy runs - [`5b4a1dd`](https://github.com/hickory-dns/hickory-dns/commit/5b4a1dd3ec8c30d3f88aa17c56364ffaedc26a34) update readme for Trust-DNS binaries - [`197aea2`](https://github.com/hickory-dns/hickory-dns/commit/197aea273e8a977e7501e2a0e1c9717b1b84d5de) fix feature compatibility ### 📊 Changes **41 files changed** (+360 additions, -422 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -1) 📝 `bin/tests/named_rustls_tests.rs` (+1 -1) 📝 `bin/tests/server_harness/mod.rs` (+1 -1) 📝 `crates/client/src/client/client_future.rs` (+1 -1) 📝 `crates/client/src/lib.rs` (+3 -0) 📝 `crates/client/src/rr/dnssec/signer.rs` (+3 -3) 📝 `crates/https/src/https_server.rs` (+3 -43) 📝 `crates/https/src/response.rs` (+1 -1) 📝 `crates/native-tls/src/tests.rs` (+1 -1) 📝 `crates/openssl/tests/openssl_tests.rs` (+1 -1) 📝 `crates/proto/src/rr/rr_set.rs` (+9 -9) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+1 -1) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+1 -1) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+2 -2) 📝 `crates/proto/src/udp/udp_stream.rs` (+1 -1) 📝 `crates/proto/src/xfer/secure_dns_handle.rs` (+114 -152) 📝 `crates/resolver/src/async_resolver/background.rs` (+2 -2) 📝 `crates/resolver/src/dns_lru.rs` (+10 -10) 📝 `crates/resolver/src/hosts.rs` (+5 -5) 📝 `crates/resolver/src/lib.rs` (+2 -0) _...and 21 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 02:25:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1784
No description provided.