[PR #901] [MERGED] Some tweaks to the `proto` API #1779

New issue

Closed

opened 2026-03-16 02:24:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:24:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/901
Author: @rotty
Created: 10/25/2019
Status: ✅ Merged
Merged: 10/26/2019
Merged by: @bluejekyll

Base: master ← Head: proto-api-tweaks

📝 Commits (3)

9edfcef proto: Do return Copy fields by value, not by reference
28eea9b proto: Implement From instead of Into for SSHFP types
47062d1 proto: Return slice instead of Vec in NULL accessor

📊 Changes

5 files changed (+19 additions, -19 deletions)

View changed files

📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+2 -2)
📝 crates/proto/src/rr/rdata/null.rs (+2 -2)
📝 crates/proto/src/rr/rdata/sshfp.rs (+6 -6)
📝 crates/proto/src/rr/rdata/tlsa.rs (+6 -6)
📝 crates/server/tests/txt_tests.rs (+3 -3)

📄 Description

This adjusts some API gotchas I've run into, and an accessor that appeared not-completely-idiomatic to me.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/901 **Author:** [@rotty](https://github.com/rotty) **Created:** 10/25/2019 **Status:** ✅ Merged **Merged:** 10/26/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `proto-api-tweaks` --- ### 📝 Commits (3) - [`9edfcef`](https://github.com/hickory-dns/hickory-dns/commit/9edfcef9d99e2f83d516164af124301fd35303d2) proto: Do return `Copy` fields by value, not by reference - [`28eea9b`](https://github.com/hickory-dns/hickory-dns/commit/28eea9b37286c86e08a410445e1b76d91be8c650) proto: Implement `From` instead of `Into` for SSHFP types - [`47062d1`](https://github.com/hickory-dns/hickory-dns/commit/47062d10e52fe3fb35a5652911739b2f45bde732) proto: Return slice instead of `Vec` in `NULL` accessor ### 📊 Changes **5 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/null.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/sshfp.rs` (+6 -6) 📝 `crates/proto/src/rr/rdata/tlsa.rs` (+6 -6) 📝 `crates/server/tests/txt_tests.rs` (+3 -3) </details> ### 📄 Description This adjusts some API gotchas I've run into, and an accessor that appeared not-completely-idiomatic to me. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>