[PR #883] [MERGED] Allow parsing DNSSEC record types #1769

New issue

Closed

opened 2026-03-16 02:24:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:24:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/883
Author: @rotty
Created: 10/14/2019
Status: ✅ Merged
Merged: 10/18/2019
Merged by: @bluejekyll

Base: master ← Head: pr/dnssec-rtype-parse

📝 Commits (2)

399f28f Allow parsing DNSSEC record types
af23e0e Merge branch 'master' into pr/dnssec-rtype-parse

📊 Changes

2 files changed (+71 additions, -0 deletions)

View changed files

📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+20 -0)
📝 crates/proto/src/rr/record_type.rs (+51 -0)

📄 Description

This now delegates the missing DNSSEC record type names in RecordType::from_str() to the newly added FromStr implementation for DNSSECRecordType.

A basic unit test doing a round-trip test of all names is included.

I'm not totally sure if this is the right way to go about this, but I figured since DNSSECRecordType can be converted to &static str, the corresponding FromStr implementation is probably desired as well, plus it seems in line with how impl From<u16> for RecordType is handled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/883 **Author:** [@rotty](https://github.com/rotty) **Created:** 10/14/2019 **Status:** ✅ Merged **Merged:** 10/18/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `pr/dnssec-rtype-parse` --- ### 📝 Commits (2) - [`399f28f`](https://github.com/hickory-dns/hickory-dns/commit/399f28ff278ac51070d2bc2bc4e8c89e65726e8f) Allow parsing DNSSEC record types - [`af23e0e`](https://github.com/hickory-dns/hickory-dns/commit/af23e0e173f9f654cb766182afdb4c09ac997bc6) Merge branch 'master' into pr/dnssec-rtype-parse ### 📊 Changes **2 files changed** (+71 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+20 -0) 📝 `crates/proto/src/rr/record_type.rs` (+51 -0) </details> ### 📄 Description This now delegates the missing DNSSEC record type names in `RecordType::from_str()` to the newly added `FromStr` implementation for `DNSSECRecordType`. A basic unit test doing a round-trip test of all names is included. ---- I'm not totally sure if this is the right way to go about this, but I figured since `DNSSECRecordType` can be converted to `&static str`, the corresponding `FromStr` implementation is probably desired as well, plus it seems in line with how `impl From<u16> for RecordType` is handled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>