[PR #889] [MERGED] Add `valid_until` method for specific resolver lookup results #1767

New issue

Closed

opened 2026-03-16 02:24:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:24:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/889
Author: @rotty
Created: 10/17/2019
Status: ✅ Merged
Merged: 10/18/2019
Merged by: @bluejekyll

Base: master ← Head: pr/valid-until-method

📝 Commits (2)

9b4ad0a Add valid_until method for specific resolver lookup results
c413f9b Merge branch 'master' into pr/valid-until-method

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 crates/resolver/src/lookup.rs (+5 -0)

📄 Description

This appeared to be an omission to me; its was when trying to construct ResolveErrorKind::NoRecordsFound given a lookup result, which contains a valid_until field when I noticed the specialized lookup results don't have this method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/889 **Author:** [@rotty](https://github.com/rotty) **Created:** 10/17/2019 **Status:** ✅ Merged **Merged:** 10/18/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `pr/valid-until-method` --- ### 📝 Commits (2) - [`9b4ad0a`](https://github.com/hickory-dns/hickory-dns/commit/9b4ad0aacacabd9b90f4cf93f8e849d32df7935b) Add `valid_until` method for specific resolver lookup results - [`c413f9b`](https://github.com/hickory-dns/hickory-dns/commit/c413f9bb636d9d509047039d8c897fbae084ce88) Merge branch 'master' into pr/valid-until-method ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/lookup.rs` (+5 -0) </details> ### 📄 Description ---- This appeared to be an omission to me; its was when trying to construct `ResolveErrorKind::NoRecordsFound` given a lookup result, which contains a `valid_until` field when I noticed the specialized lookup results don't have this method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>