[PR #881] [MERGED] `rusqlite` is now an optional crate #1765

New issue

Closed

opened 2026-03-16 02:24:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:24:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/881
Author: @c410-f3r
Created: 10/12/2019
Status: ✅ Merged
Merged: 10/14/2019
Merged by: @bluejekyll

Base: master ← Head: sqlite

📝 Commits (4)

1d45506 rusqlite is now an optional crate
0ed3324 Fix Clippy issues
8511269 Use expect instead of match
5869c59 Merge branch 'master' into sqlite

📊 Changes

35 files changed (+88 additions, -146 deletions)

View changed files

📝 crates/client/src/client/memoize_client_handle.rs (+2 -2)
📝 crates/client/src/rr/dnssec/key_format.rs (+4 -4)
📝 crates/proto/src/rr/dnssec/rdata/dnskey.rs (+3 -6)
📝 crates/proto/src/rr/dnssec/rdata/ds.rs (+3 -6)
📝 crates/proto/src/rr/dnssec/rdata/key.rs (+3 -6)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+3 -6)
📝 crates/proto/src/rr/dnssec/rdata/nsec3.rs (+6 -12)
📝 crates/proto/src/rr/dnssec/rdata/nsec3param.rs (+2 -6)
📝 crates/proto/src/rr/dnssec/rdata/sig.rs (+3 -6)
📝 crates/proto/src/rr/domain/name.rs (+2 -2)
📝 crates/proto/src/rr/rdata/mx.rs (+2 -6)
📝 crates/proto/src/rr/rdata/name.rs (+2 -6)
📝 crates/proto/src/rr/rdata/naptr.rs (+2 -6)
📝 crates/proto/src/rr/rdata/null.rs (+3 -6)
📝 crates/proto/src/rr/rdata/opt.rs (+3 -6)
📝 crates/proto/src/rr/rdata/soa.rs (+2 -6)
📝 crates/proto/src/rr/rdata/srv.rs (+3 -6)
📝 crates/proto/src/rr/rdata/txt.rs (+3 -6)
📝 crates/proto/src/tcp/tcp_stream.rs (+1 -0)
📝 crates/resolver/src/async_resolver/mod.rs (+1 -2)

...and 15 more files

📄 Description

Fixes #833.

I did my best but I am not sure if all tests of all crates are passing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/881 **Author:** [@c410-f3r](https://github.com/c410-f3r) **Created:** 10/12/2019 **Status:** ✅ Merged **Merged:** 10/14/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `sqlite` --- ### 📝 Commits (4) - [`1d45506`](https://github.com/hickory-dns/hickory-dns/commit/1d45506a99370a2810f3ece09a85a241fc00ad48) `rusqlite` is now an optional crate - [`0ed3324`](https://github.com/hickory-dns/hickory-dns/commit/0ed3324d2668e07c0168f49cfb67c3436e103744) Fix Clippy issues - [`8511269`](https://github.com/hickory-dns/hickory-dns/commit/851126940cff00dca746df3188afb8877a42d1cb) Use expect instead of match - [`5869c59`](https://github.com/hickory-dns/hickory-dns/commit/5869c594ba47c63eafee22b883e935eb391ed7dc) Merge branch 'master' into sqlite ### 📊 Changes **35 files changed** (+88 additions, -146 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/memoize_client_handle.rs` (+2 -2) 📝 `crates/client/src/rr/dnssec/key_format.rs` (+4 -4) 📝 `crates/proto/src/rr/dnssec/rdata/dnskey.rs` (+3 -6) 📝 `crates/proto/src/rr/dnssec/rdata/ds.rs` (+3 -6) 📝 `crates/proto/src/rr/dnssec/rdata/key.rs` (+3 -6) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+3 -6) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3.rs` (+6 -12) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3param.rs` (+2 -6) 📝 `crates/proto/src/rr/dnssec/rdata/sig.rs` (+3 -6) 📝 `crates/proto/src/rr/domain/name.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/mx.rs` (+2 -6) 📝 `crates/proto/src/rr/rdata/name.rs` (+2 -6) 📝 `crates/proto/src/rr/rdata/naptr.rs` (+2 -6) 📝 `crates/proto/src/rr/rdata/null.rs` (+3 -6) 📝 `crates/proto/src/rr/rdata/opt.rs` (+3 -6) 📝 `crates/proto/src/rr/rdata/soa.rs` (+2 -6) 📝 `crates/proto/src/rr/rdata/srv.rs` (+3 -6) 📝 `crates/proto/src/rr/rdata/txt.rs` (+3 -6) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+1 -0) 📝 `crates/resolver/src/async_resolver/mod.rs` (+1 -2) _...and 15 more files_ </details> ### 📄 Description Fixes #833. I did my best but I am not sure if all tests of all crates are passing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>