[PR #844] [MERGED] Remove byteorder-dependency #1732

New issue

Closed

opened 2026-03-16 02:22:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:22:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/844
Author: @lukaslueg
Created: 8/7/2019
Status: ✅ Merged
Merged: 8/7/2019
Merged by: @bluejekyll

Base: master ← Head: byteorder_removed

📝 Commits (1)

0f9aaf3 Remove byteorder-dependency

📊 Changes

5 files changed (+6 additions, -24 deletions)

View changed files

📝 Cargo.lock (+0 -1)
📝 crates/proto/Cargo.toml (+0 -1)
📝 crates/proto/src/lib.rs (+0 -1)
📝 crates/proto/src/serialize/binary/decoder.rs (+3 -4)
📝 crates/proto/src/serialize/binary/encoder.rs (+3 -17)

📄 Description

This removes the byteorder-dependency, which is not strictly needed since the stdlib-implementations went stable in 1.32. Dropping a dependency is worth the small change IMHO.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/844 **Author:** [@lukaslueg](https://github.com/lukaslueg) **Created:** 8/7/2019 **Status:** ✅ Merged **Merged:** 8/7/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `byteorder_removed` --- ### 📝 Commits (1) - [`0f9aaf3`](https://github.com/hickory-dns/hickory-dns/commit/0f9aaf385c30b3d7bb1bf01eaba66e97c59ab933) Remove byteorder-dependency ### 📊 Changes **5 files changed** (+6 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -1) 📝 `crates/proto/Cargo.toml` (+0 -1) 📝 `crates/proto/src/lib.rs` (+0 -1) 📝 `crates/proto/src/serialize/binary/decoder.rs` (+3 -4) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+3 -17) </details> ### 📄 Description This removes the `byteorder`-dependency, which is not strictly needed since the `stdlib`-implementations went stable in 1.32. Dropping a dependency is worth the small change IMHO. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>