[PR #800] [MERGED] Introduce Unknown algorithm enum variant #1692

New issue

Closed

opened 2026-03-16 02:20:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:20:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/800
Author: @zackangelo
Created: 6/18/2019
Status: ✅ Merged
Merged: 6/18/2019
Merged by: @bluejekyll

Base: master ← Head: unknown_algo

📝 Commits (1)

7d6835d Introduce Unknown algorithm enum variant

📊 Changes

8 files changed (+66 additions, -40 deletions)

View changed files

📝 crates/client/src/rr/dnssec/key_format.rs (+6 -0)
📝 crates/client/src/rr/dnssec/keypair.rs (+6 -0)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+21 -16)
📝 crates/proto/src/rr/dnssec/digest_type.rs (+2 -0)
📝 crates/proto/src/rr/dnssec/public_key.rs (+0 -1)
📝 crates/proto/src/rr/dnssec/supported_algorithm.rs (+23 -18)
📝 util/src/bind_dnskey_to_pem.rs (+4 -2)
📝 util/src/get_root_ksks.rs (+4 -3)

📄 Description

The DNSSEC algorithm type spec specifies type numbers that we do not currently handle and may expand unforeseeably in the future given the reserved identifier range.

Introducing an Unknown variant to the Algorithm enum ensures that any logic using it is required to handle these future cases.

Additionally, it fixes a bug in which the client fails to parse a response an RRSIG record containing a currently valid enum type number (253, reserved for private algorithms).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/800 **Author:** [@zackangelo](https://github.com/zackangelo) **Created:** 6/18/2019 **Status:** ✅ Merged **Merged:** 6/18/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `unknown_algo` --- ### 📝 Commits (1) - [`7d6835d`](https://github.com/hickory-dns/hickory-dns/commit/7d6835dc4d3aaf6f0bbe4d5fadc87acb89bfd7a8) Introduce Unknown algorithm enum variant ### 📊 Changes **8 files changed** (+66 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/rr/dnssec/key_format.rs` (+6 -0) 📝 `crates/client/src/rr/dnssec/keypair.rs` (+6 -0) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+21 -16) 📝 `crates/proto/src/rr/dnssec/digest_type.rs` (+2 -0) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+0 -1) 📝 `crates/proto/src/rr/dnssec/supported_algorithm.rs` (+23 -18) 📝 `util/src/bind_dnskey_to_pem.rs` (+4 -2) 📝 `util/src/get_root_ksks.rs` (+4 -3) </details> ### 📄 Description The [DNSSEC algorithm type spec](https://www.iana.org/assignments/dns-sec-alg-numbers/dns-sec-alg-numbers.xhtml) specifies type numbers that we do not currently handle and may expand unforeseeably in the future given the reserved identifier range. Introducing an `Unknown` variant to the Algorithm enum ensures that any logic using it is required to handle these future cases. Additionally, it fixes a bug in which the client fails to parse a response an RRSIG record containing a currently valid enum type number (253, reserved for private algorithms). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>