[PR #794] [MERGED] [trust-dns-proto] Make TcpStream as generic type #1690

New issue

Closed

opened 2026-03-16 02:20:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:20:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/794
Author: @chunyingw
Created: 6/13/2019
Status: ✅ Merged
Merged: 6/16/2019
Merged by: @bluejekyll

Base: master ← Head: tcp

📝 Commits (10+)

dce776f [Make tcpstream as a generic type]
8ec8391 [Make trust_dns_::Tcpstream as a generic type]
65182d5 Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
681fd66 Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
a2beffa Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
9ac4b25 [Make trust_dns::Tcpstream as a generic type]
e224b1c Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
dc78bbb Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
4c39618 Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize
2fae0a2 [trust-dns-proto] Make TcpStream as generic type

📊 Changes

18 files changed (+127 additions, -79 deletions)

View changed files

📝 crates/client/src/tcp/tcp_client_connection.rs (+1 -1)
📝 crates/https/Cargo.toml (+1 -1)
📝 crates/native-tls/Cargo.toml (+1 -1)
📝 crates/proto/Cargo.toml (+5 -2)
📝 crates/proto/src/lib.rs (+1 -1)
📝 crates/proto/src/tcp/mod.rs (+1 -2)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+23 -12)
📝 crates/proto/src/tcp/tcp_stream.rs (+29 -14)
📝 crates/resolver/Cargo.toml (+1 -0)
📝 crates/resolver/src/lib.rs (+1 -0)
📝 crates/resolver/src/name_server/connection_provider.rs (+4 -2)
📝 crates/rustls/Cargo.toml (+1 -1)
📝 crates/server/benches/comparison_benches.rs (+19 -14)
📝 crates/server/tests/server_harness/mut_message_client.rs (+1 -1)
📝 crates/server/tests/z_named_test_rsa_dnssec.rs (+6 -2)
📝 crates/server/tests/z_named_tests.rs (+14 -12)
📝 tests/integration-tests/tests/client_future_tests.rs (+6 -3)
📝 tests/integration-tests/tests/secure_client_handle_tests.rs (+12 -10)

📄 Description

Abstract trust_dns_proto::TcpStream and related types
Make tokio-tcp as optional dependencies
run rustfmt on the files modifed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/794 **Author:** [@chunyingw](https://github.com/chunyingw) **Created:** 6/13/2019 **Status:** ✅ Merged **Merged:** 6/16/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `tcp` --- ### 📝 Commits (10+) - [`dce776f`](https://github.com/hickory-dns/hickory-dns/commit/dce776f007adaa58a9a97cc04a685f540a25a7c8) [Make tcpstream as a generic type] - [`8ec8391`](https://github.com/hickory-dns/hickory-dns/commit/8ec8391d533a266d1984d85e67f70f985089fe06) [Make trust_dns_::Tcpstream as a generic type] - [`65182d5`](https://github.com/hickory-dns/hickory-dns/commit/65182d5d6ced7141b665f9c5114daac182bffb2a) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`681fd66`](https://github.com/hickory-dns/hickory-dns/commit/681fd66f10019a849d57e2b3ae53a0b28b25e9e5) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`a2beffa`](https://github.com/hickory-dns/hickory-dns/commit/a2beffa8971ca577b322da89b3d9a7119c212a6e) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`9ac4b25`](https://github.com/hickory-dns/hickory-dns/commit/9ac4b251d9506b475f40019066f14d790be30920) [Make trust_dns::Tcpstream as a generic type] - [`e224b1c`](https://github.com/hickory-dns/hickory-dns/commit/e224b1cd8396deefd96d1df8491fa9f7ae1e94a3) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`dc78bbb`](https://github.com/hickory-dns/hickory-dns/commit/dc78bbbd400c87ee5c08992fc0166cb4af66a148) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`4c39618`](https://github.com/hickory-dns/hickory-dns/commit/4c3961816fa30856832256a47cc3d29f25bf145d) Merge branch 'organize' of https://github.com/chunyingw/trust-dns into organize - [`2fae0a2`](https://github.com/hickory-dns/hickory-dns/commit/2fae0a29b75bd9c3efe36bb454fa09dd8906a72c) [trust-dns-proto] Make TcpStream as generic type ### 📊 Changes **18 files changed** (+127 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/tcp/tcp_client_connection.rs` (+1 -1) 📝 `crates/https/Cargo.toml` (+1 -1) 📝 `crates/native-tls/Cargo.toml` (+1 -1) 📝 `crates/proto/Cargo.toml` (+5 -2) 📝 `crates/proto/src/lib.rs` (+1 -1) 📝 `crates/proto/src/tcp/mod.rs` (+1 -2) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+23 -12) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+29 -14) 📝 `crates/resolver/Cargo.toml` (+1 -0) 📝 `crates/resolver/src/lib.rs` (+1 -0) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+4 -2) 📝 `crates/rustls/Cargo.toml` (+1 -1) 📝 `crates/server/benches/comparison_benches.rs` (+19 -14) 📝 `crates/server/tests/server_harness/mut_message_client.rs` (+1 -1) 📝 `crates/server/tests/z_named_test_rsa_dnssec.rs` (+6 -2) 📝 `crates/server/tests/z_named_tests.rs` (+14 -12) 📝 `tests/integration-tests/tests/client_future_tests.rs` (+6 -3) 📝 `tests/integration-tests/tests/secure_client_handle_tests.rs` (+12 -10) </details> ### 📄 Description - Abstract trust_dns_proto::TcpStream and related types - Make tokio-tcp as optional dependencies - run rustfmt on the files modifed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>