[PR #721] [CLOSED] Create a parser state #1632

New issue

Closed

opened 2026-03-16 02:17:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:17:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/721
Author: @makarchuk
Created: 3/29/2019
Status: ❌ Closed

Base: master ← Head: parser-state

📝 Commits (2)

8f27d4e Separate structure to hold parser state
d4e884d Fix set_current_name call, to work properly

📊 Changes

1 file changed (+140 additions, -90 deletions)

View changed files

📝 crates/client/src/serialize/txt/master.rs (+140 -90)

📄 Description

Create a parser state object to try and reduce complexity of parsing function.

Original idea was to address #718 , but it seems like original ttl handling was actually RFC-compliant, so the only result of it is rathrer questionable refactoring.

Please feel free to close this MR, if it's not what you were looking for.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/721 **Author:** [@makarchuk](https://github.com/makarchuk) **Created:** 3/29/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `parser-state` --- ### 📝 Commits (2) - [`8f27d4e`](https://github.com/hickory-dns/hickory-dns/commit/8f27d4ee125865033a4be8f2f6883439213f1632) Separate structure to hold parser state - [`d4e884d`](https://github.com/hickory-dns/hickory-dns/commit/d4e884df8d720b25c265610c13cbfb9104a10aec) Fix set_current_name call, to work properly ### 📊 Changes **1 file changed** (+140 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/master.rs` (+140 -90) </details> ### 📄 Description Create a parser state object to try and reduce complexity of parsing function. Original idea was to address #718 , but it seems like original `ttl` handling was actually RFC-compliant, so the only result of it is rathrer questionable refactoring. Please feel free to close this MR, if it's not what you were looking for. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>