[PR #720] [MERGED] Support ANAME and fixup CNAME support #1631

New issue

Closed

opened 2026-03-16 02:17:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:17:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/720
Author: @bluejekyll
Created: 3/29/2019
Status: ✅ Merged
Merged: 4/4/2019
Merged by: @bluejekyll

Base: master ← Head: support-aname

📝 Commits (7)

a89669e create ANAME record type
4aaf090 fixup CNAME usage in the server
fc1e24f append additional records for CNAME in response
3326708 ANAME tests
03cb6d6 add ANAME to additionals
ab2e581 fix NSEC storage at CNAME
e5d059d pick a proper temp value for ANAME

📊 Changes

22 files changed (+1150 additions, -201 deletions)

View changed files

📝 README.md (+1 -0)
📝 crates/client/src/serialize/txt/parse_rdata.rs (+2 -0)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+24 -8)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+4 -7)
📝 crates/proto/src/rr/record_data.rs (+91 -7)
📝 crates/proto/src/rr/record_type.rs (+8 -0)
📝 crates/proto/src/rr/rr_set.rs (+23 -2)
📝 crates/proto/src/serialize/binary/encoder.rs (+14 -0)
📝 crates/server/src/authority/auth_lookup.rs (+57 -5)
📝 crates/server/src/authority/authority_object.rs (+9 -0)
📝 crates/server/src/authority/catalog.rs (+46 -39)
📝 crates/server/src/authority/message_response.rs (+16 -10)
📝 crates/server/src/store/file/authority.rs (+3 -5)
📝 crates/server/src/store/forwarder/authority.rs (+4 -0)
📝 crates/server/src/store/in_memory/authority.rs (+288 -33)
📝 crates/server/src/store/sqlite/authority.rs (+1 -3)
📝 crates/server/tests/authority_battery/basic.rs (+285 -21)
📝 crates/server/tests/named_test_configs/example.com.zone (+16 -6)
📝 crates/server/tests/txt_tests.rs (+109 -34)
📝 tests/integration-tests/src/authority.rs (+29 -3)

...and 2 more files

📄 Description

I'll file a separate PR for ANAME support in the resolver.

fyi: #513

Also, it looks like CNAME was most likely broken before, where the server not even aliasing names properly before. This fixes that, and adds a bunch of tests for CNAME.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/720 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 3/29/2019 **Status:** ✅ Merged **Merged:** 4/4/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support-aname` --- ### 📝 Commits (7) - [`a89669e`](https://github.com/hickory-dns/hickory-dns/commit/a89669e2414e4b1f15dbf665223ca197240dcf03) create ANAME record type - [`4aaf090`](https://github.com/hickory-dns/hickory-dns/commit/4aaf0904c336a45ea5713a4ab8509e426a0482a1) fixup CNAME usage in the server - [`fc1e24f`](https://github.com/hickory-dns/hickory-dns/commit/fc1e24f43c0bea23f66cc0c809c6a92ca60a853d) append additional records for CNAME in response - [`3326708`](https://github.com/hickory-dns/hickory-dns/commit/3326708a59beb7f4b511fa942d2446f0e6931df8) ANAME tests - [`03cb6d6`](https://github.com/hickory-dns/hickory-dns/commit/03cb6d6f9a08278ac8b02899268b495720af366e) add ANAME to additionals - [`ab2e581`](https://github.com/hickory-dns/hickory-dns/commit/ab2e581e30b9907803121a9f2277b930031f13e4) fix NSEC storage at CNAME - [`e5d059d`](https://github.com/hickory-dns/hickory-dns/commit/e5d059dba4e2d0192e2fdbe45b907044a63a3bdb) pick a proper temp value for ANAME ### 📊 Changes **22 files changed** (+1150 additions, -201 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `crates/client/src/serialize/txt/parse_rdata.rs` (+2 -0) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+24 -8) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+4 -7) 📝 `crates/proto/src/rr/record_data.rs` (+91 -7) 📝 `crates/proto/src/rr/record_type.rs` (+8 -0) 📝 `crates/proto/src/rr/rr_set.rs` (+23 -2) 📝 `crates/proto/src/serialize/binary/encoder.rs` (+14 -0) 📝 `crates/server/src/authority/auth_lookup.rs` (+57 -5) 📝 `crates/server/src/authority/authority_object.rs` (+9 -0) 📝 `crates/server/src/authority/catalog.rs` (+46 -39) 📝 `crates/server/src/authority/message_response.rs` (+16 -10) 📝 `crates/server/src/store/file/authority.rs` (+3 -5) 📝 `crates/server/src/store/forwarder/authority.rs` (+4 -0) 📝 `crates/server/src/store/in_memory/authority.rs` (+288 -33) 📝 `crates/server/src/store/sqlite/authority.rs` (+1 -3) 📝 `crates/server/tests/authority_battery/basic.rs` (+285 -21) 📝 `crates/server/tests/named_test_configs/example.com.zone` (+16 -6) 📝 `crates/server/tests/txt_tests.rs` (+109 -34) 📝 `tests/integration-tests/src/authority.rs` (+29 -3) _...and 2 more files_ </details> ### 📄 Description I'll file a separate PR for ANAME support in the resolver. fyi: #513 Also, it looks like CNAME was most likely broken before, where the server not even aliasing names properly before. This fixes that, and adds a bunch of tests for CNAME. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>