[PR #684] [MERGED] Remove extra "/" that causes issue with dummy parsers #1602

Closed
opened 2026-03-16 02:15:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/684
Author: @detro
Created: 2/10/2019
Status: Merged
Merged: 2/11/2019
Merged by: @bluejekyll

Base: masterHead: patch-1


📝 Commits (1)

  • 01f5b67 Remove extra "/" that causes issue with dummy parsers

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 crates/proto/src/rr/record_data.rs (+2 -2)

📄 Description

While this should be something that shouldn't cause troubles, the IntelliJ Rust plugin parser is unable to interpret any code after a comment line that contains 4 instead of 3 characters.

I have of course raised the issue with the IntelliJ-Rust plugin project (here), but given it's a typo, I thought: why not fix it?

BTW: I have done a quick "grep -r" on the repo and I couldn't find any other occurence of this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/684 **Author:** [@detro](https://github.com/detro) **Created:** 2/10/2019 **Status:** ✅ Merged **Merged:** 2/11/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`01f5b67`](https://github.com/hickory-dns/hickory-dns/commit/01f5b67daa443397222759fbc1b1c640d57e24bb) Remove extra "/" that causes issue with dummy parsers ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/record_data.rs` (+2 -2) </details> ### 📄 Description While this should be something that shouldn't cause troubles, the IntelliJ Rust plugin parser is unable to interpret any code after a comment line that contains 4 instead of 3 characters. I have of course raised the issue with the IntelliJ-Rust plugin project ([here](https://github.com/intellij-rust/intellij-rust/issues/3379)), but given it's a typo, I thought: why not fix it? BTW: I have done a quick "grep -r" on the repo and I couldn't find any other occurence of this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 02:15:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1602
No description provided.