mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-26 03:35:52 +03:00
[PR #684] [MERGED] Remove extra "/" that causes issue with dummy parsers #1602
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1602
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/684
Author: @detro
Created: 2/10/2019
Status: ✅ Merged
Merged: 2/11/2019
Merged by: @bluejekyll
Base:
master← Head:patch-1📝 Commits (1)
01f5b67Remove extra "/" that causes issue with dummy parsers📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
crates/proto/src/rr/record_data.rs(+2 -2)📄 Description
While this should be something that shouldn't cause troubles, the IntelliJ Rust plugin parser is unable to interpret any code after a comment line that contains 4 instead of 3 characters.
I have of course raised the issue with the IntelliJ-Rust plugin project (here), but given it's a typo, I thought: why not fix it?
BTW: I have done a quick "grep -r" on the repo and I couldn't find any other occurence of this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.