[PR #651] [MERGED] maintain AsyncResolver in Resolver #1580

New issue

Closed

opened 2026-03-16 02:14:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:14:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/651
Author: @bluejekyll
Created: 1/8/2019
Status: ✅ Merged
Merged: 1/9/2019
Merged by: @bluejekyll

Base: master ← Head: maintain-async-resolver

📝 Commits (2)

531722e maintain AsyncResolver in Resolver
76f1a35 fix tokio warnings

📊 Changes

4 files changed (+54 additions, -63 deletions)

View changed files

📝 crates/proto/src/multicast/mdns_stream.rs (+15 -14)
📝 crates/resolver/src/error.rs (+7 -1)
📝 crates/resolver/src/resolver.rs (+30 -46)
📝 crates/server/src/server/server_future.rs (+2 -2)

📄 Description

When the synchronous Resolver is instantiated, it will create a Tokio Runtime for it to perform DNS queries. Due to the nature of parallel requests, there will be multiple TLS streams established. This might be something we want to improve in the future, but is beyond the scope of this PR.

fixes #650

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/651 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/8/2019 **Status:** ✅ Merged **Merged:** 1/9/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `maintain-async-resolver` --- ### 📝 Commits (2) - [`531722e`](https://github.com/hickory-dns/hickory-dns/commit/531722e58e7adc2cd0542d16938142714a2e901b) maintain AsyncResolver in Resolver - [`76f1a35`](https://github.com/hickory-dns/hickory-dns/commit/76f1a356860539917342435fc5bc8bd1e14c76d2) fix tokio warnings ### 📊 Changes **4 files changed** (+54 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/multicast/mdns_stream.rs` (+15 -14) 📝 `crates/resolver/src/error.rs` (+7 -1) 📝 `crates/resolver/src/resolver.rs` (+30 -46) 📝 `crates/server/src/server/server_future.rs` (+2 -2) </details> ### 📄 Description When the synchronous Resolver is instantiated, it will create a Tokio Runtime for it to perform DNS queries. Due to the nature of parallel requests, there will be multiple TLS streams established. This might be something we want to improve in the future, but is beyond the scope of this PR. fixes #650 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>