[PR #622] [MERGED] move persistence to sqlite module #1560

New issue

Closed

opened 2026-03-16 02:13:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:13:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/622
Author: @bluejekyll
Created: 11/21/2018
Status: ✅ Merged
Merged: 1/19/2019
Merged by: @bluejekyll

Base: master ← Head: refactor_to_sqlite_module

📝 Commits (6)

c5a1000 move persistence to sqlite module
0e6aac8 change from lifetime rrset returns to Arc
46a8a6f add battery of tests for authorities
c3c845f update configurateion parse to support file and sqlite
37c877b initial dynamic update insert test
2c95472 cleanup clippy errors

📊 Changes

77 files changed (+5351 additions, -3275 deletions)

View changed files

📝 .rustfmt.toml (+3 -3)
📝 CHANGELOG.md (+2 -0)
📝 copyright.txt (+1 -1)
📝 crates/client/src/client/client.rs (+7 -7)
📝 crates/client/src/client/client_future.rs (+23 -210)
📝 crates/client/src/client/mod.rs (+1 -1)
📝 crates/client/src/op/lower_query.rs (+14 -0)
📝 crates/client/src/op/mod.rs (+1 -1)
📝 crates/client/src/op/update_message.rs (+431 -2)
📝 crates/client/src/rr/dnssec/keypair.rs (+4 -6)
📝 crates/client/src/rr/dnssec/signer.rs (+40 -26)
📝 crates/client/src/rr/mod.rs (+1 -0)
➖ crates/client/src/rr/rr_set.rs (+0 -805)
📝 crates/client/src/serialize/txt/master.rs (+2 -2)
📝 crates/proto/Cargo.toml (+1 -0)
📝 crates/proto/src/lib.rs (+2 -0)
📝 crates/proto/src/op/message.rs (+1 -1)
📝 crates/proto/src/op/response_code.rs (+0 -1)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+16 -18)
📝 crates/proto/src/rr/dnssec/public_key.rs (+6 -3)

...and 57 more files

📄 Description

Cleaning up file based, and sqlite server authority implementations. This is refactoring work to prepare for additional backends.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/622 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/21/2018 **Status:** ✅ Merged **Merged:** 1/19/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `refactor_to_sqlite_module` --- ### 📝 Commits (6) - [`c5a1000`](https://github.com/hickory-dns/hickory-dns/commit/c5a10001e79cd0ebbd74c470b1c82a4fe8cd24bf) move persistence to sqlite module - [`0e6aac8`](https://github.com/hickory-dns/hickory-dns/commit/0e6aac8349151ef00bbe27d747041797a935e558) change from lifetime rrset returns to Arc - [`46a8a6f`](https://github.com/hickory-dns/hickory-dns/commit/46a8a6f253d31cf76fd8e1f528d01d81effc252e) add battery of tests for authorities - [`c3c845f`](https://github.com/hickory-dns/hickory-dns/commit/c3c845f2bfbd19de2b0b4e6be4b7e048b254fce2) update configurateion parse to support file and sqlite - [`37c877b`](https://github.com/hickory-dns/hickory-dns/commit/37c877bc844befd680e6e91e48d842dffbde9423) initial dynamic update insert test - [`2c95472`](https://github.com/hickory-dns/hickory-dns/commit/2c954721276b80c2cba303afe1a478d7bb342552) cleanup clippy errors ### 📊 Changes **77 files changed** (+5351 additions, -3275 deletions) <details> <summary>View changed files</summary> 📝 `.rustfmt.toml` (+3 -3) 📝 `CHANGELOG.md` (+2 -0) 📝 `copyright.txt` (+1 -1) 📝 `crates/client/src/client/client.rs` (+7 -7) 📝 `crates/client/src/client/client_future.rs` (+23 -210) 📝 `crates/client/src/client/mod.rs` (+1 -1) 📝 `crates/client/src/op/lower_query.rs` (+14 -0) 📝 `crates/client/src/op/mod.rs` (+1 -1) 📝 `crates/client/src/op/update_message.rs` (+431 -2) 📝 `crates/client/src/rr/dnssec/keypair.rs` (+4 -6) 📝 `crates/client/src/rr/dnssec/signer.rs` (+40 -26) 📝 `crates/client/src/rr/mod.rs` (+1 -0) ➖ `crates/client/src/rr/rr_set.rs` (+0 -805) 📝 `crates/client/src/serialize/txt/master.rs` (+2 -2) 📝 `crates/proto/Cargo.toml` (+1 -0) 📝 `crates/proto/src/lib.rs` (+2 -0) 📝 `crates/proto/src/op/message.rs` (+1 -1) 📝 `crates/proto/src/op/response_code.rs` (+0 -1) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+16 -18) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+6 -3) _...and 57 more files_ </details> ### 📄 Description Cleaning up file based, and sqlite server authority implementations. This is refactoring work to prepare for additional backends. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>