[PR #613] [MERGED] on servfail, continue requests to other nameservers #1555

New issue

Closed

opened 2026-03-16 02:12:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:12:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/613
Author: @bluejekyll
Created: 11/12/2018
Status: ✅ Merged
Merged: 11/13/2018
Merged by: @bluejekyll

Base: master ← Head: continue-to-other-nameservers-on-error

📝 Commits (2)

0c29e54 on servfail, continue requests to other nameservers
ae0336f fix mdns tests

📊 Changes

4 files changed (+153 additions, -17 deletions)

View changed files

📝 crates/resolver/CHANGELOG.md (+6 -0)
📝 crates/resolver/src/config.rs (+4 -0)
📝 crates/resolver/src/name_server_pool.rs (+17 -0)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+126 -17)

📄 Description

When SERVFAIL is returned by Nameserver, this change will cause the request to fail. This has the effect of transitioning to another Namerserver in the NameserverPool.

fixes #606

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/613 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 11/12/2018 **Status:** ✅ Merged **Merged:** 11/13/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `continue-to-other-nameservers-on-error` --- ### 📝 Commits (2) - [`0c29e54`](https://github.com/hickory-dns/hickory-dns/commit/0c29e54e974adb12275ae6151695229212612037) on servfail, continue requests to other nameservers - [`ae0336f`](https://github.com/hickory-dns/hickory-dns/commit/ae0336f993a23ac9ab05eccead43148c0a37390b) fix mdns tests ### 📊 Changes **4 files changed** (+153 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/CHANGELOG.md` (+6 -0) 📝 `crates/resolver/src/config.rs` (+4 -0) 📝 `crates/resolver/src/name_server_pool.rs` (+17 -0) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+126 -17) </details> ### 📄 Description When SERVFAIL is returned by Nameserver, this change will cause the request to fail. This has the effect of transitioning to another Namerserver in the NameserverPool. fixes #606 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>