[PR #602] [MERGED] Make tokio-rustls optional for server #1547

Closed
opened 2026-03-16 02:12:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/602
Author: @sticnarf
Created: 11/3/2018
Status: Merged
Merged: 11/3/2018
Merged by: @bluejekyll

Base: masterHead: make-tokio-rustls-optional-for-server


📝 Commits (1)

  • cc05ae1 Make tokio-rustls optional for server

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 crates/server/Cargo.toml (+3 -3)

📄 Description

tokio-rustls is only used when feature dns-over-https-rustls or dns-over-rustls is enabled.

So, we should make it optional to prevent introducing unnecessary dependencies when rustls is not used.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/602 **Author:** [@sticnarf](https://github.com/sticnarf) **Created:** 11/3/2018 **Status:** ✅ Merged **Merged:** 11/3/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `make-tokio-rustls-optional-for-server` --- ### 📝 Commits (1) - [`cc05ae1`](https://github.com/hickory-dns/hickory-dns/commit/cc05ae1ddb95cbb7a6ee9693e032c18d52ab799d) Make tokio-rustls optional for server ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/Cargo.toml` (+3 -3) </details> ### 📄 Description `tokio-rustls` is only used when feature `dns-over-https-rustls` or `dns-over-rustls` is enabled. So, we should make it optional to prevent introducing unnecessary dependencies when rustls is not used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 02:12:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1547
No description provided.