[PR #601] [MERGED] Expose the originating Query from Lookup #1546

New issue

Closed

opened 2026-03-16 02:12:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:12:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/601
Author: @olix0r
Created: 11/2/2018
Status: ✅ Merged
Merged: 11/2/2018
Merged by: @bluejekyll

Base: master ← Head: ver/lookup-query

📝 Commits (4)

7d72ac3 Expose the originating Query from Lookup
7d991aa Fix compilation for integration-tests
a7b45bd Synthesize reasonable queries when a query is not specified
0d898c6 Avoid exposing the Vec type for rdatas

📊 Changes

7 files changed (+106 additions, -74 deletions)

View changed files

📝 crates/resolver/src/async_resolver/background.rs (+7 -8)
📝 crates/resolver/src/dns_lru.rs (+1 -1)
📝 crates/resolver/src/hosts.rs (+18 -5)
📝 crates/resolver/src/lookup.rs (+31 -9)
📝 crates/resolver/src/lookup_ip.rs (+2 -3)
📝 crates/resolver/src/lookup_state.rs (+43 -47)
📝 tests/integration-tests/tests/lookup_tests.rs (+4 -1)

📄 Description

When resolving a relative name like foo.bar with a search path like
a.b c.d, it's not currently possible to know which FQDN actually
resolved (e.g., foo.bar.a.b., foo.bar.c.d., or foo.bar.).

This change modifies the Lookup type to include the Query that
was looked up.

Fixes bluejekyll/trust-dns#599

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/601 **Author:** [@olix0r](https://github.com/olix0r) **Created:** 11/2/2018 **Status:** ✅ Merged **Merged:** 11/2/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `ver/lookup-query` --- ### 📝 Commits (4) - [`7d72ac3`](https://github.com/hickory-dns/hickory-dns/commit/7d72ac39a6104039752326a8867b2cbc2005750f) Expose the originating Query from Lookup - [`7d991aa`](https://github.com/hickory-dns/hickory-dns/commit/7d991aa8d61bb343e484bbbd04b8e70b0966ebf7) Fix compilation for integration-tests - [`a7b45bd`](https://github.com/hickory-dns/hickory-dns/commit/a7b45bda4f40ab530552f5c679c10a058d3739ab) Synthesize reasonable queries when a query is not specified - [`0d898c6`](https://github.com/hickory-dns/hickory-dns/commit/0d898c64071c3dcdf9ace4be770cd1f1e471d691) Avoid exposing the Vec type for rdatas ### 📊 Changes **7 files changed** (+106 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/async_resolver/background.rs` (+7 -8) 📝 `crates/resolver/src/dns_lru.rs` (+1 -1) 📝 `crates/resolver/src/hosts.rs` (+18 -5) 📝 `crates/resolver/src/lookup.rs` (+31 -9) 📝 `crates/resolver/src/lookup_ip.rs` (+2 -3) 📝 `crates/resolver/src/lookup_state.rs` (+43 -47) 📝 `tests/integration-tests/tests/lookup_tests.rs` (+4 -1) </details> ### 📄 Description When resolving a relative name like `foo.bar` with a search path like `a.b c.d`, it's not currently possible to know which FQDN actually resolved (e.g., `foo.bar.a.b.`, `foo.bar.c.d.`, or `foo.bar.`). This change modifies the `Lookup` type to include the `Query` that was looked up. Fixes bluejekyll/trust-dns#599 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>