[PR #595] [MERGED] Don't require DnsExchange in ClientFuture usage #1542

New issue

Closed

opened 2026-03-16 02:12:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:12:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/595
Author: @bluejekyll
Created: 10/27/2018
Status: ✅ Merged
Merged: 10/28/2018
Merged by: @bluejekyll

Base: master ← Head: simplify-client-xfer-impl

📝 Commits (3)

2b81f94 Don't require DnsExchange in ClientFuture usage
3eafd38 unbox some of multiplexer usage
99e30fe fix benches

📊 Changes

24 files changed (+264 additions, -329 deletions)

View changed files

📝 crates/client/src/client/client.rs (+5 -5)
📝 crates/client/src/client/client_connection.rs (+2 -10)
📝 crates/client/src/client/client_future.rs (+24 -40)
📝 crates/client/src/https_client_connection.rs (+5 -12)
📝 crates/client/src/multicast/mdns_client_connection.rs (+6 -14)
📝 crates/client/src/tcp/tcp_client_connection.rs (+5 -15)
📝 crates/client/src/udp/udp_client_connection.rs (+6 -16)
📝 crates/proto/src/multicast/mdns_client_stream.rs (+16 -12)
📝 crates/proto/src/multicast/mod.rs (+6 -6)
📝 crates/proto/src/op/message.rs (+1 -1)
📝 crates/proto/src/tcp/mod.rs (+1 -1)
📝 crates/proto/src/tcp/tcp_client_stream.rs (+7 -4)
📝 crates/proto/src/tcp/tcp_stream.rs (+28 -23)
📝 crates/proto/src/udp/mod.rs (+1 -1)
📝 crates/proto/src/udp/udp_client_stream.rs (+14 -6)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+23 -17)
📝 crates/server/benches/comparison_benches.rs (+4 -7)
📝 crates/server/tests/z_named_https_tests.rs (+3 -4)
📝 crates/server/tests/z_named_test_rsa_dnssec.rs (+3 -3)
📝 tests/integration-tests/src/lib.rs (+8 -12)

...and 4 more files

📄 Description

This should simplify the ClientFuture usage a bit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/595 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/27/2018 **Status:** ✅ Merged **Merged:** 10/28/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `simplify-client-xfer-impl` --- ### 📝 Commits (3) - [`2b81f94`](https://github.com/hickory-dns/hickory-dns/commit/2b81f94e0bc013ebb845716a79c7d62554255528) Don't require DnsExchange in ClientFuture usage - [`3eafd38`](https://github.com/hickory-dns/hickory-dns/commit/3eafd388089ab2d9b1276a1ff4aacb9885c3b82b) unbox some of multiplexer usage - [`99e30fe`](https://github.com/hickory-dns/hickory-dns/commit/99e30febdfa8d046107db6eac9d3db36c944eaf0) fix benches ### 📊 Changes **24 files changed** (+264 additions, -329 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/client/client.rs` (+5 -5) 📝 `crates/client/src/client/client_connection.rs` (+2 -10) 📝 `crates/client/src/client/client_future.rs` (+24 -40) 📝 `crates/client/src/https_client_connection.rs` (+5 -12) 📝 `crates/client/src/multicast/mdns_client_connection.rs` (+6 -14) 📝 `crates/client/src/tcp/tcp_client_connection.rs` (+5 -15) 📝 `crates/client/src/udp/udp_client_connection.rs` (+6 -16) 📝 `crates/proto/src/multicast/mdns_client_stream.rs` (+16 -12) 📝 `crates/proto/src/multicast/mod.rs` (+6 -6) 📝 `crates/proto/src/op/message.rs` (+1 -1) 📝 `crates/proto/src/tcp/mod.rs` (+1 -1) 📝 `crates/proto/src/tcp/tcp_client_stream.rs` (+7 -4) 📝 `crates/proto/src/tcp/tcp_stream.rs` (+28 -23) 📝 `crates/proto/src/udp/mod.rs` (+1 -1) 📝 `crates/proto/src/udp/udp_client_stream.rs` (+14 -6) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+23 -17) 📝 `crates/server/benches/comparison_benches.rs` (+4 -7) 📝 `crates/server/tests/z_named_https_tests.rs` (+3 -4) 📝 `crates/server/tests/z_named_test_rsa_dnssec.rs` (+3 -3) 📝 `tests/integration-tests/src/lib.rs` (+8 -12) _...and 4 more files_ </details> ### 📄 Description This should simplify the ClientFuture usage a bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>