[PR #566] [MERGED] Delays all connections until actual use. #1519

New issue

Closed

opened 2026-03-16 02:10:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:10:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/566
Author: @bluejekyll
Created: 10/3/2018
Status: ✅ Merged
Merged: 10/5/2018
Merged by: @bluejekyll

Base: master ← Head: fix_reconnect_issues

📝 Commits (7)

f9c170c Delays all connections until actual use.
de579a1 demote standard connection shutdown msgs to debug
136a45f make NameServerConnect failable
1c44377 delay all tokio::spawns until Future is polled
6ba16de Fix multithreaded example
e531359 remove unnecessary mem::replace usage
550e782 switch back to DefaultExecutor

📊 Changes

6 files changed (+303 additions, -118 deletions)

View changed files

📝 proto/src/error.rs (+24 -1)
📝 proto/src/xfer/dns_exchange.rs (+1 -1)
📝 resolver/Cargo.toml (+1 -1)
📝 resolver/examples/multithreaded_runtime.rs (+6 -4)
📝 resolver/src/async_resolver/background.rs (+3 -1)
📝 resolver/src/name_server_pool.rs (+268 -110)

📄 Description

This also changes the ordering to prefer established connections over others.
It also fixes an issue with established connections being dropped early.
Also, demoting connection shutdown to debug from error

fixes: #532
fixes: #560
fixes: #546
fixes: #524

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/566 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/3/2018 **Status:** ✅ Merged **Merged:** 10/5/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_reconnect_issues` --- ### 📝 Commits (7) - [`f9c170c`](https://github.com/hickory-dns/hickory-dns/commit/f9c170c78467cc78467f44127766f0ae0bbfd6d1) Delays all connections until actual use. - [`de579a1`](https://github.com/hickory-dns/hickory-dns/commit/de579a129e1a72f2d536ea4f738d03a41e01e665) demote standard connection shutdown msgs to debug - [`136a45f`](https://github.com/hickory-dns/hickory-dns/commit/136a45f3fa72df0a62b701f88619138c64eda124) make NameServerConnect failable - [`1c44377`](https://github.com/hickory-dns/hickory-dns/commit/1c44377c6eac3200fbbaaaa0cf66a9634030f15d) delay all tokio::spawns until Future is polled - [`6ba16de`](https://github.com/hickory-dns/hickory-dns/commit/6ba16deae310a1058faba6721ddf9069a53c0cb3) Fix multithreaded example - [`e531359`](https://github.com/hickory-dns/hickory-dns/commit/e5313599810a95a00fffa3695fe8f5bdc2582d4d) remove unnecessary mem::replace usage - [`550e782`](https://github.com/hickory-dns/hickory-dns/commit/550e782ef359eb57d2af47ab3e7a70cb5ac573ba) switch back to DefaultExecutor ### 📊 Changes **6 files changed** (+303 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/error.rs` (+24 -1) 📝 `proto/src/xfer/dns_exchange.rs` (+1 -1) 📝 `resolver/Cargo.toml` (+1 -1) 📝 `resolver/examples/multithreaded_runtime.rs` (+6 -4) 📝 `resolver/src/async_resolver/background.rs` (+3 -1) 📝 `resolver/src/name_server_pool.rs` (+268 -110) </details> ### 📄 Description This also changes the ordering to prefer established connections over others. It also fixes an issue with established connections being dropped early. Also, demoting connection shutdown to debug from error fixes: #532 fixes: #560 fixes: #546 fixes: #524 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>