[PR #568] [MERGED] Fix multithreaded example #1518

New issue

Closed

opened 2026-03-16 02:10:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:10:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/568
Author: @hawkw
Created: 10/4/2018
Status: ✅ Merged
Merged: 10/4/2018
Merged by: @bluejekyll

Base: fix_reconnect_issues ← Head: eliza/fix-multithreaded-example

📝 Commits (1)

3b07122 Fix multithreaded example

📊 Changes

2 files changed (+4 additions, -5 deletions)

View changed files

📝 resolver/Cargo.toml (+1 -1)
📝 resolver/examples/multithreaded_runtime.rs (+3 -4)

📄 Description

This branch fixes the multithreaded_runtime example by replacing calls to Future::wait with tokio:runtime::Runtime::block_on, and waiting to shut down the runtime until after the calls to block_on.

Note that this requires updating the minimum tokio dependency to version 0.1.7, as the Runtime::block_on method was added in this version.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/568 **Author:** [@hawkw](https://github.com/hawkw) **Created:** 10/4/2018 **Status:** ✅ Merged **Merged:** 10/4/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `fix_reconnect_issues` ← **Head:** `eliza/fix-multithreaded-example` --- ### 📝 Commits (1) - [`3b07122`](https://github.com/hickory-dns/hickory-dns/commit/3b0712227e79e74844f04b636577c1bdcbb8c64e) Fix multithreaded example ### 📊 Changes **2 files changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `resolver/Cargo.toml` (+1 -1) 📝 `resolver/examples/multithreaded_runtime.rs` (+3 -4) </details> ### 📄 Description This branch fixes the `multithreaded_runtime` example by replacing calls to `Future::wait` with `tokio:runtime::Runtime::block_on`, and waiting to shut down the runtime until after the calls to `block_on`. Note that this requires updating the minimum `tokio` dependency to version 0.1.7, as the `Runtime::block_on` method was added in this version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>