mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[PR #570] [CLOSED] (RFC) Prefer Queen and Drone for Primary and Secondary references #1517
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#1517
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hickory-dns/hickory-dns/pull/570
Author: @bluejekyll
Created: 10/6/2018
Status: ❌ Closed
Base:
master← Head:change_all_master-slave_to_queen-drone📝 Commits (1)
bb9150cPrefer Queen and Drone for Primary and Secondary references📊 Changes
13 files changed (+262 additions, -212 deletions)
View changed files
📝
README.md(+7 -0)📝
client/src/client/client.rs(+11 -11)📝
client/src/client/client_future.rs(+24 -24)📝
integration-tests/src/authority.rs(+1 -1)📝
integration-tests/tests/authority_tests.rs(+2 -2)📝
integration-tests/tests/catalog_tests.rs(+9 -17)📝
proto/src/rr/rdata/soa.rs(+4 -4)📝
server/src/authority/authority.rs(+117 -99)📝
server/src/authority/catalog.rs(+8 -8)📝
server/src/authority/mod.rs(+5 -1)📝
server/src/config.rs(+15 -7)📝
server/tests/config_tests.rs(+46 -15)📝
server/tests/txt_tests.rs(+13 -23)📄 Description
In an attempt to remove morally questionable terms from the library, all references to ‘master’ and ‘slave’ have been replaced with ‘queen’ and ‘drone’.
I like these terms, but as I haven’t seen them in wide usage, I figure it’s important for others to weigh in. I find them more interesting and colorful than ‘primary’ and ‘secondary’, which would be another, more bland, option possibly more clear due to their general usage.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.