[PR #557] [MERGED] DNS over HTTPS suppor in server & client #1511

Closed
opened 2026-03-16 02:10:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/557
Author: @bluejekyll
Created: 9/9/2018
Status: Merged
Merged: 9/25/2018
Merged by: @bluejekyll

Base: masterHead: https_server_client


📝 Commits (10+)

  • 736e366 https test in place for server
  • 3b6d5a1 https server and client working
  • 734b803 add from_post unit test
  • 430b4c6 fix no-default-features
  • c0c2e3b fix dns-over-openssl feature
  • 4daf0d7 fix dns-over-rustls tests
  • deb5a4e fixup dnssec tests
  • 5cfa0a6 fix all-features tests
  • b2ac740 fix macro_use for failure in https
  • 8f0d604 added support for dns-over-rustls

📊 Changes

57 files changed (+2117 additions, -657 deletions)

View changed files

📝 CHANGELOG.md (+9 -0)
📝 client/Cargo.toml (+10 -3)
📝 client/src/client/client.rs (+2 -2)
📝 client/src/client/client_future.rs (+1 -0)
📝 client/src/lib.rs (+1 -1)
📝 client/src/op/lower_query.rs (+2 -2)
📝 https/Cargo.toml (+2 -0)
https/src/error.rs (+115 -0)
📝 https/src/https_client_stream.rs (+61 -87)
https/src/https_server.rs (+199 -0)
📝 https/src/lib.rs (+14 -1)
https/src/request.rs (+149 -0)
https/src/response.rs (+61 -0)
📝 integration-tests/Cargo.toml (+6 -3)
📝 integration-tests/src/authority.rs (+13 -25)
📝 integration-tests/src/lib.rs (+1 -1)
📝 integration-tests/tests/authority_tests.rs (+34 -57)
📝 integration-tests/tests/client_future_tests.rs (+14 -3)
📝 integration-tests/tests/client_tests.rs (+17 -1)
📝 integration-tests/tests/secure_client_handle_tests.rs (+2 -0)

...and 37 more files

📄 Description

This continues the work of supporting DNS-over-HTTPS (DoH) in TRust-DNS started with the resolver.

  • integrates h2 library via the trust-dns-https crate
  • All are feature flagged with dns-over-https-rustls
    -- openssl support is planned, and will be dns-over-https-openssl
  • trust-dns crate (client) gains DoH
  • trust-dns-server crate gains DoH

Things left to do before merging:

  • enable dns-over-rustls
  • rework server config files for rustls key types
  • support pem chain and separate key (like rustls) for openssl
  • cleanup TODOs and FIXMEs related to https support

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/557 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 9/9/2018 **Status:** ✅ Merged **Merged:** 9/25/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `https_server_client` --- ### 📝 Commits (10+) - [`736e366`](https://github.com/hickory-dns/hickory-dns/commit/736e3667b32f9fca88e9d4a6b5f7720e4ce66dca) https test in place for server - [`3b6d5a1`](https://github.com/hickory-dns/hickory-dns/commit/3b6d5a1641da02f56d20bfff9e09e9eff30e3a70) https server and client working - [`734b803`](https://github.com/hickory-dns/hickory-dns/commit/734b80393e8f0e4a25ea776078abd2e8627c4a0d) add from_post unit test - [`430b4c6`](https://github.com/hickory-dns/hickory-dns/commit/430b4c6d9b1d2f45907ecf06d9aa191121685618) fix no-default-features - [`c0c2e3b`](https://github.com/hickory-dns/hickory-dns/commit/c0c2e3b6a3b75c365d5bd6f8561933961aa1870c) fix dns-over-openssl feature - [`4daf0d7`](https://github.com/hickory-dns/hickory-dns/commit/4daf0d7e0b335f9df44efb7590bf6dcaeea15b96) fix dns-over-rustls tests - [`deb5a4e`](https://github.com/hickory-dns/hickory-dns/commit/deb5a4ea7cc022e4ee8977fd23bb0b7f3ca46850) fixup dnssec tests - [`5cfa0a6`](https://github.com/hickory-dns/hickory-dns/commit/5cfa0a633a9e9f48c187e8a9661db4c95e9dd87e) fix all-features tests - [`b2ac740`](https://github.com/hickory-dns/hickory-dns/commit/b2ac740a67c3c0be05030fe5cf8b5509d9f522d4) fix macro_use for failure in https - [`8f0d604`](https://github.com/hickory-dns/hickory-dns/commit/8f0d604e6d837b69cf33788b9e5d5a6281a42e32) added support for dns-over-rustls ### 📊 Changes **57 files changed** (+2117 additions, -657 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+9 -0) 📝 `client/Cargo.toml` (+10 -3) 📝 `client/src/client/client.rs` (+2 -2) 📝 `client/src/client/client_future.rs` (+1 -0) 📝 `client/src/lib.rs` (+1 -1) 📝 `client/src/op/lower_query.rs` (+2 -2) 📝 `https/Cargo.toml` (+2 -0) ➕ `https/src/error.rs` (+115 -0) 📝 `https/src/https_client_stream.rs` (+61 -87) ➕ `https/src/https_server.rs` (+199 -0) 📝 `https/src/lib.rs` (+14 -1) ➕ `https/src/request.rs` (+149 -0) ➕ `https/src/response.rs` (+61 -0) 📝 `integration-tests/Cargo.toml` (+6 -3) 📝 `integration-tests/src/authority.rs` (+13 -25) 📝 `integration-tests/src/lib.rs` (+1 -1) 📝 `integration-tests/tests/authority_tests.rs` (+34 -57) 📝 `integration-tests/tests/client_future_tests.rs` (+14 -3) 📝 `integration-tests/tests/client_tests.rs` (+17 -1) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+2 -0) _...and 37 more files_ </details> ### 📄 Description This continues the work of supporting DNS-over-HTTPS (DoH) in TRust-DNS started with the resolver. - integrates h2 library via the `trust-dns-https` crate - All are feature flagged with `dns-over-https-rustls` -- openssl support is planned, and will be `dns-over-https-openssl` - trust-dns crate (client) gains DoH - trust-dns-server crate gains DoH Things left to do before merging: - [x] enable `dns-over-rustls` - [x] rework server config files for rustls key types - [x] support pem chain and separate key (like rustls) for openssl - [x] cleanup `TODO`s and `FIXME`s related to https support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 02:10:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1511
No description provided.