[PR #554] [MERGED] upgrade rusqlite to avoid future compatibility problem #1510

New issue

Closed

opened 2026-03-16 02:10:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:10:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/554
Author: @hdhoang
Created: 9/1/2018
Status: ✅ Merged
Merged: 9/3/2018
Merged by: @bluejekyll

Base: master ← Head: rusqlite-upgrade

📝 Commits (2)

95a3930 upgrade rusqlite to avoid future compatibility problem
45657db Merge branch 'master' into rusqlite-upgrade

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 integration-tests/Cargo.toml (+1 -1)
📝 server/Cargo.toml (+1 -1)
📝 server/src/error/persistence_error.rs (+2 -2)

📄 Description

due to rust-lang/rust#49799

Compatibility note: with 0.14, rusqlite's result count type is now usize. I have chosen to cast it to i32 instead of changing WrongInsertCount, since it's a public type.

Should I also add a note to upgrade to usize when trust-dns-server bump major version? Or should I make the switch right away (it seems 0.15 is already in the work)?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/554 **Author:** [@hdhoang](https://github.com/hdhoang) **Created:** 9/1/2018 **Status:** ✅ Merged **Merged:** 9/3/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `rusqlite-upgrade` --- ### 📝 Commits (2) - [`95a3930`](https://github.com/hickory-dns/hickory-dns/commit/95a3930b7714109ab846566ea26a15441f5f680a) upgrade rusqlite to avoid future compatibility problem - [`45657db`](https://github.com/hickory-dns/hickory-dns/commit/45657db185e5ecd68dbd82c18c07eb665119187b) Merge branch 'master' into rusqlite-upgrade ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `integration-tests/Cargo.toml` (+1 -1) 📝 `server/Cargo.toml` (+1 -1) 📝 `server/src/error/persistence_error.rs` (+2 -2) </details> ### 📄 Description due to rust-lang/rust#49799 Compatibility note: with 0.14, rusqlite's result count type is now usize. I have chosen to cast it to i32 instead of changing `WrongInsertCount`, since it's a public type. Should I also add a note to upgrade to usize when trust-dns-server bump major version? Or should I make the switch right away (it seems 0.15 is already in the work)? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>