[PR #518] [CLOSED] (wip) Refactor streams to serial message #1493

New issue

Closed

opened 2026-03-16 02:09:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:09:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/518
Author: @bluejekyll
Created: 6/24/2018
Status: ❌ Closed

Base: master ← Head: refactor-streams-to-serial-message

📝 Commits (10+)

c760af2 initial HttpsClientStream impl
b7e97ec redo the interface for the HttpsClientStream
ff16639 add query parameter for query
df05a26 add basic test
09a791e initial working HttpsClientStream
2ef9dd9 enable automated tests for https
f9a16b3 cleanup response handling states
a989c67 make DnsStreamHandle on DnsFuture generic
4fc9357 convert all streams to SerialMessage
c1e5eca refactor send_message to directly return a Future

📊 Changes

33 files changed (+1333 additions, -169 deletions)

View changed files

📝 Cargo.toml (+1 -10)
📝 client/src/client/client_connection.rs (+2 -1)
📝 client/src/client/client_future.rs (+3 -3)
➕ https/Cargo.toml (+65 -0)
➕ https/README.md (+9 -0)
➕ https/src/https_client_stream.rs (+625 -0)
➕ https/src/lib.rs (+35 -0)
📝 integration-tests/src/lib.rs (+7 -6)
📝 integration-tests/tests/server_future_tests.rs (+38 -24)
📝 native-tls/src/tests.rs (+9 -6)
📝 openssl/tests/openssl_tests.rs (+10 -7)
📝 proto/src/error.rs (+2 -2)
📝 proto/src/tcp/tcp_client_stream.rs (+12 -15)
📝 proto/src/tcp/tcp_stream.rs (+19 -14)
📝 proto/src/udp/udp_client_stream.rs (+16 -19)
📝 proto/src/udp/udp_stream.rs (+11 -11)
📝 proto/src/xfer/dns_future.rs (+18 -17)
📝 proto/src/xfer/dns_handle.rs (+2 -2)
➕ proto/src/xfer/dns_stream.rs (+211 -0)
📝 proto/src/xfer/mod.rs (+94 -7)

...and 13 more files

📄 Description

this builds on top of #509

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/518 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 6/24/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactor-streams-to-serial-message` --- ### 📝 Commits (10+) - [`c760af2`](https://github.com/hickory-dns/hickory-dns/commit/c760af2324d8c037c9cdfe8aba756d06ed159718) initial HttpsClientStream impl - [`b7e97ec`](https://github.com/hickory-dns/hickory-dns/commit/b7e97ec8c9ebf77e3c2a042887972d040c2d753d) redo the interface for the HttpsClientStream - [`ff16639`](https://github.com/hickory-dns/hickory-dns/commit/ff166391ab656136b1b8a30c43f34d0b53e4f6f8) add query parameter for query - [`df05a26`](https://github.com/hickory-dns/hickory-dns/commit/df05a26eb4839636b1124262c63ed440b2150e25) add basic test - [`09a791e`](https://github.com/hickory-dns/hickory-dns/commit/09a791e6fe2299499e67ce427fdc8794d52afad0) initial working HttpsClientStream - [`2ef9dd9`](https://github.com/hickory-dns/hickory-dns/commit/2ef9dd94c2b8670a9586e543e3766112c5302132) enable automated tests for https - [`f9a16b3`](https://github.com/hickory-dns/hickory-dns/commit/f9a16b3fdf3ed416dd78b36a21ebc98f722d240b) cleanup response handling states - [`a989c67`](https://github.com/hickory-dns/hickory-dns/commit/a989c673c44d1242caa4ef705ded5d28d60d5072) make DnsStreamHandle on DnsFuture generic - [`4fc9357`](https://github.com/hickory-dns/hickory-dns/commit/4fc93576156f94428f07a39a65bf1c726ebf3d16) convert all streams to SerialMessage - [`c1e5eca`](https://github.com/hickory-dns/hickory-dns/commit/c1e5eca37b3529be0335ec4887f93575a745dcf3) refactor send_message to directly return a Future ### 📊 Changes **33 files changed** (+1333 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -10) 📝 `client/src/client/client_connection.rs` (+2 -1) 📝 `client/src/client/client_future.rs` (+3 -3) ➕ `https/Cargo.toml` (+65 -0) ➕ `https/README.md` (+9 -0) ➕ `https/src/https_client_stream.rs` (+625 -0) ➕ `https/src/lib.rs` (+35 -0) 📝 `integration-tests/src/lib.rs` (+7 -6) 📝 `integration-tests/tests/server_future_tests.rs` (+38 -24) 📝 `native-tls/src/tests.rs` (+9 -6) 📝 `openssl/tests/openssl_tests.rs` (+10 -7) 📝 `proto/src/error.rs` (+2 -2) 📝 `proto/src/tcp/tcp_client_stream.rs` (+12 -15) 📝 `proto/src/tcp/tcp_stream.rs` (+19 -14) 📝 `proto/src/udp/udp_client_stream.rs` (+16 -19) 📝 `proto/src/udp/udp_stream.rs` (+11 -11) 📝 `proto/src/xfer/dns_future.rs` (+18 -17) 📝 `proto/src/xfer/dns_handle.rs` (+2 -2) ➕ `proto/src/xfer/dns_stream.rs` (+211 -0) 📝 `proto/src/xfer/mod.rs` (+94 -7) _...and 13 more files_ </details> ### 📄 Description this builds on top of #509 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>