[PR #498] [MERGED] resolver: Add missing `fmt::Debug`s and re-export returned futures #1485

New issue

Closed

opened 2026-03-16 02:08:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:08:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/498
Author: @hawkw
Created: 5/29/2018
Status: ✅ Merged
Merged: 5/30/2018
Merged by: @bluejekyll

Base: master ← Head: eliza/async-resolver-api-improvement

📝 Commits (1)

bac2758 resolver: Add missing fmt::Debugs and re-export returned futures

📊 Changes

2 files changed (+20 additions, -2 deletions)

View changed files

📝 resolver/src/async_resolver/mod.rs (+14 -1)
📝 resolver/src/lib.rs (+6 -1)

📄 Description

This PR fixes a handful of minor usability issues in the new
AsyncResolver's API that I hit while trying to use it downstream in
runconduit/conduit#1033. In particular, it adds a missing fmt::Debug
implementation to AsyncResolver (since the old ResolverFuture
implemented fmt::Debug, and not implementing it may break
downstream code that tries to format it), and publically re-exports
the futures returned by AsyncResolver's lookup methods, so that
their types are actually nameable in downstream code.

Signed-off-by: Eliza Weisman eliza@buoyant.io

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/498 **Author:** [@hawkw](https://github.com/hawkw) **Created:** 5/29/2018 **Status:** ✅ Merged **Merged:** 5/30/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `eliza/async-resolver-api-improvement` --- ### 📝 Commits (1) - [`bac2758`](https://github.com/hickory-dns/hickory-dns/commit/bac275861377faca4686df264a7104da95301880) resolver: Add missing `fmt::Debug`s and re-export returned futures ### 📊 Changes **2 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `resolver/src/async_resolver/mod.rs` (+14 -1) 📝 `resolver/src/lib.rs` (+6 -1) </details> ### 📄 Description This PR fixes a handful of minor usability issues in the new `AsyncResolver`'s API that I hit while trying to use it downstream in runconduit/conduit#1033. In particular, it adds a missing `fmt::Debug` implementation to `AsyncResolver` (since the old `ResolverFuture` implemented `fmt::Debug`, and not implementing it may break downstream code that tries to format it), and publically re-exports the futures returned by `AsyncResolver`'s lookup methods, so that their types are actually nameable in downstream code. Signed-off-by: Eliza Weisman <eliza@buoyant.io> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>