[PR #502] [MERGED] server: switch comparison_benches to use tokio-executor #1481

New issue

Closed

opened 2026-03-16 02:08:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:08:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/502
Author: @nholstein
Created: 5/31/2018
Status: ✅ Merged
Merged: 6/2/2018
Merged by: @bluejekyll

Base: master ← Head: bench-tokio-executor

📝 Commits (2)

e87ef48 server: switch comparison_benches to tokio-executor.
33e25d9 Build benchmark tests in Travis.

📊 Changes

3 files changed (+47 additions, -35 deletions)

View changed files

📝 .travis.yml (+6 -0)
➕ scripts/build_benches.sh (+10 -0)
📝 server/benches/comparison_benches.rs (+31 -35)

📄 Description

Client APIs changed during the switch to tokio-executor, but the uses in comparison_benches weren't updated.

See commit eb1f6102: Initial conversion to tokio-executor.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/502 **Author:** [@nholstein](https://github.com/nholstein) **Created:** 5/31/2018 **Status:** ✅ Merged **Merged:** 6/2/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `bench-tokio-executor` --- ### 📝 Commits (2) - [`e87ef48`](https://github.com/hickory-dns/hickory-dns/commit/e87ef48bf0335a73d23bebc789a5a4ddbf180a24) server: switch comparison_benches to tokio-executor. - [`33e25d9`](https://github.com/hickory-dns/hickory-dns/commit/33e25d96e9d96b8444aa0f5d05c72bb2a281457e) Build benchmark tests in Travis. ### 📊 Changes **3 files changed** (+47 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+6 -0) ➕ `scripts/build_benches.sh` (+10 -0) 📝 `server/benches/comparison_benches.rs` (+31 -35) </details> ### 📄 Description Client APIs changed during the switch to tokio-executor, but the uses in comparison_benches weren't updated. See commit eb1f6102: Initial conversion to tokio-executor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>