[PR #467] [MERGED] fix for ipv4 early return/search #1458

New issue

Closed

opened 2026-03-16 02:07:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:07:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/467
Author: @bluejekyll
Created: 5/15/2018
Status: ✅ Merged
Merged: 5/17/2018
Merged by: @bluejekyll

Base: master ← Head: fix-ipv4-search

📝 Commits (3)

7d4c537 proposed fix for ipv4 early return/search
ee53238 add tests for ipv4 fall through
a665eeb fix nsec integration tests

📊 Changes

4 files changed (+209 additions, -27 deletions)

View changed files

📝 integration-tests/src/authority.rs (+8 -17)
📝 integration-tests/tests/lookup_tests.rs (+87 -2)
📝 resolver/src/lookup_ip.rs (+9 -0)
📝 resolver/src/resolver_future.rs (+105 -8)

📄 Description

If ndots is greater than for, then this skips the early return of the IP address, and delays that until the final result after performing all other queries.

fixes: #431

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/467 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/15/2018 **Status:** ✅ Merged **Merged:** 5/17/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-ipv4-search` --- ### 📝 Commits (3) - [`7d4c537`](https://github.com/hickory-dns/hickory-dns/commit/7d4c53728278ee1e500d67e2f3b978b36287d2ba) proposed fix for ipv4 early return/search - [`ee53238`](https://github.com/hickory-dns/hickory-dns/commit/ee532382380b887cf162ce1bdd946049ec05c792) add tests for ipv4 fall through - [`a665eeb`](https://github.com/hickory-dns/hickory-dns/commit/a665eebb43985e573d0b499b0afec6b55727ca2c) fix nsec integration tests ### 📊 Changes **4 files changed** (+209 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `integration-tests/src/authority.rs` (+8 -17) 📝 `integration-tests/tests/lookup_tests.rs` (+87 -2) 📝 `resolver/src/lookup_ip.rs` (+9 -0) 📝 `resolver/src/resolver_future.rs` (+105 -8) </details> ### 📄 Description If ndots is greater than for, then this skips the early return of the IP address, and delays that until the final result after performing all other queries. fixes: #431 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>