[PR #457] [MERGED] always attempt reconnect when nameserver is picked #1455

New issue

Closed

opened 2026-03-16 02:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/457
Author: @bluejekyll
Created: 5/12/2018
Status: ✅ Merged
Merged: 5/15/2018
Merged by: @bluejekyll

Base: master ← Head: fix-no-nameservers

📝 Commits (6)

7eb2079 always attempt reconnect when nameserver is picked
a39fc6d prefer established connections
19e895d switch to sorted Vec for connections...
33b2542 loop over all name_servers in the case of a failure
6a3bf21 Merge branch 'master' into fix-no-nameservers
3116744 Merge branch 'master' into fix-no-nameservers

📊 Changes

1 file changed (+91 additions, -76 deletions)

View changed files

📝 resolver/src/name_server_pool.rs (+91 -76)

📄 Description

Currently the NameServerPool can be exhausted when connections are not reattempted. This should make sure that connects will always be attempted even if all the connections are failed.

fixes: #454

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/457 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/12/2018 **Status:** ✅ Merged **Merged:** 5/15/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-no-nameservers` --- ### 📝 Commits (6) - [`7eb2079`](https://github.com/hickory-dns/hickory-dns/commit/7eb2079072579a5f842acf39243e03a576c1197e) always attempt reconnect when nameserver is picked - [`a39fc6d`](https://github.com/hickory-dns/hickory-dns/commit/a39fc6d521568d1190cc86ce97edfc283f346a16) prefer established connections - [`19e895d`](https://github.com/hickory-dns/hickory-dns/commit/19e895d033fcb6f1972e8e7be4b9b249f3c899c7) switch to sorted Vec for connections... - [`33b2542`](https://github.com/hickory-dns/hickory-dns/commit/33b254230009343eb511892da0b3894a3e3fceb1) loop over all name_servers in the case of a failure - [`6a3bf21`](https://github.com/hickory-dns/hickory-dns/commit/6a3bf21a10981eadfe2c9ebf2c02b3e63468815c) Merge branch 'master' into fix-no-nameservers - [`3116744`](https://github.com/hickory-dns/hickory-dns/commit/3116744a88d3e8a28f86a5f93b787e19bf00f61e) Merge branch 'master' into fix-no-nameservers ### 📊 Changes **1 file changed** (+91 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `resolver/src/name_server_pool.rs` (+91 -76) </details> ### 📄 Description Currently the NameServerPool can be exhausted when connections are not reattempted. This should make sure that connects will always be attempted even if all the connections are failed. fixes: #454 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>