[PR #460] [MERGED] Fix send sync for DnsHandle and Resolver, etc #1453

New issue

Closed

opened 2026-03-16 02:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/460
Author: @bluejekyll
Created: 5/13/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @bluejekyll

Base: master ← Head: fix-send-sync

📝 Commits (6)

8724a8b ensure the basics are Send
212b49b Lookups sendable
d6e9fb1 fix all libraries to return Send from DnsHandle::send
245e45c add global_resolver example
848f023 fix query_depth tracking
f0f3da9 clean up global example a little

📊 Changes

20 files changed (+339 additions, -179 deletions)

View changed files

📝 client/src/client/client.rs (+31 -31)
📝 client/src/client/client_future.rs (+12 -19)
📝 client/src/client/memoize_client_handle.rs (+13 -11)
📝 client/src/client/rc_future.rs (+25 -21)
📝 integration-tests/src/mock_client.rs (+1 -1)
📝 proto/src/error.rs (+7 -9)
📝 proto/src/rr/mod.rs (+1 -1)
📝 proto/src/xfer/dns_handle.rs (+5 -5)
📝 proto/src/xfer/retry_dns_handle.rs (+5 -5)
📝 proto/src/xfer/secure_dns_handle.rs (+10 -10)
📝 resolver/Cargo.toml (+3 -0)
➕ resolver/examples/global_resolver.rs (+141 -0)
📝 resolver/src/lib.rs (+4 -0)
📝 resolver/src/lookup.rs (+4 -4)
📝 resolver/src/lookup_ip.rs (+14 -14)
📝 resolver/src/lookup_state.rs (+18 -12)
📝 resolver/src/name_server_pool.rs (+17 -34)
📝 resolver/src/resolver_future.rs (+24 -1)
📝 scripts/test_default_features.sh (+3 -0)
📝 server/tests/server_harness/mut_message_client.rs (+1 -1)

📄 Description

fixes: #456

edit, issues for the below will be filed so that this can be merged into master ASAP:

need to clean up the Client library
need to refactor DnsHandle send return to IntoFuture, to clean up interefaces
probably other things as well...
need an example with global Resolver.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/460 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 5/13/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-send-sync` --- ### 📝 Commits (6) - [`8724a8b`](https://github.com/hickory-dns/hickory-dns/commit/8724a8b7b7acac4f55bc20ab47f9fca51e1eb72b) ensure the basics are Send - [`212b49b`](https://github.com/hickory-dns/hickory-dns/commit/212b49ba2e5c82d0c761863c16c6ac5c89fd436c) Lookups sendable - [`d6e9fb1`](https://github.com/hickory-dns/hickory-dns/commit/d6e9fb19b1bf616fd6df28c892f399f7cb10d1ed) fix all libraries to return Send from DnsHandle::send - [`245e45c`](https://github.com/hickory-dns/hickory-dns/commit/245e45c67fdd80c070da851edb1ffdf6abbd3d27) add global_resolver example - [`848f023`](https://github.com/hickory-dns/hickory-dns/commit/848f023522f0fc77014d0a2727dbd8a4a7ce08c2) fix query_depth tracking - [`f0f3da9`](https://github.com/hickory-dns/hickory-dns/commit/f0f3da9e00808b7b27655b4a8d13daee8c1c4ff5) clean up global example a little ### 📊 Changes **20 files changed** (+339 additions, -179 deletions) <details> <summary>View changed files</summary> 📝 `client/src/client/client.rs` (+31 -31) 📝 `client/src/client/client_future.rs` (+12 -19) 📝 `client/src/client/memoize_client_handle.rs` (+13 -11) 📝 `client/src/client/rc_future.rs` (+25 -21) 📝 `integration-tests/src/mock_client.rs` (+1 -1) 📝 `proto/src/error.rs` (+7 -9) 📝 `proto/src/rr/mod.rs` (+1 -1) 📝 `proto/src/xfer/dns_handle.rs` (+5 -5) 📝 `proto/src/xfer/retry_dns_handle.rs` (+5 -5) 📝 `proto/src/xfer/secure_dns_handle.rs` (+10 -10) 📝 `resolver/Cargo.toml` (+3 -0) ➕ `resolver/examples/global_resolver.rs` (+141 -0) 📝 `resolver/src/lib.rs` (+4 -0) 📝 `resolver/src/lookup.rs` (+4 -4) 📝 `resolver/src/lookup_ip.rs` (+14 -14) 📝 `resolver/src/lookup_state.rs` (+18 -12) 📝 `resolver/src/name_server_pool.rs` (+17 -34) 📝 `resolver/src/resolver_future.rs` (+24 -1) 📝 `scripts/test_default_features.sh` (+3 -0) 📝 `server/tests/server_harness/mut_message_client.rs` (+1 -1) </details> ### 📄 Description fixes: #456 edit, issues for the below will be filed so that this can be merged into master ASAP: - need to clean up the Client library - need to refactor DnsHandle send return to IntoFuture, to clean up interefaces - probably other things as well... - need an example with global Resolver. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>