[PR #445] [MERGED] resolver, client: minor documentation updates #1443

New issue

Closed

opened 2026-03-16 02:06:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:06:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/445
Author: @hawkw
Created: 5/2/2018
Status: ✅ Merged
Merged: 5/3/2018
Merged by: @bluejekyll

Base: master ← Head: eliza/update-resolver-docs

📝 Commits (3)

d1d63b4 resolver, client: update docs to no longer imply resolver depends on client
1ebcf9c resolver: fix some spelling and grammar errors in docs
6319345 Merge branch 'master' into eliza/update-resolver-docs

📊 Changes

4 files changed (+6 additions, -6 deletions)

View changed files

📝 client/src/lib.rs (+1 -1)
📝 resolver/README.md (+3 -3)
📝 resolver/src/lib.rs (+1 -1)
📝 resolver/src/lookup_ip.rs (+1 -1)

📄 Description

This PR consists of two commits: the first updates the documentation for trust-dns::Client and trust-dns-resolver to no longer imply that trust-dns-resolver depends on Client (see https://github.com/runconduit/conduit/issues/711#issuecomment-385803754), and the second fixes a handful of other spelling and grammar errors I noticed while working on the first commit. Hopefully bundling these changes together in one PR is okay.

Note that I didn't read all the comments in TRust-DNS, so the second commit in this PR should definitely not be considered a complete editing pass; I just fixed the low-hanging fruit I had noticed while working in the codebase. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/445 **Author:** [@hawkw](https://github.com/hawkw) **Created:** 5/2/2018 **Status:** ✅ Merged **Merged:** 5/3/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `eliza/update-resolver-docs` --- ### 📝 Commits (3) - [`d1d63b4`](https://github.com/hickory-dns/hickory-dns/commit/d1d63b4d7ba52b58e6d1851f047fe28af38d3e05) resolver, client: update docs to no longer imply `resolver` depends on `client` - [`1ebcf9c`](https://github.com/hickory-dns/hickory-dns/commit/1ebcf9c6f8805487021f96744ea1a1950c471a39) resolver: fix some spelling and grammar errors in docs - [`6319345`](https://github.com/hickory-dns/hickory-dns/commit/63193456c863bd32da9b06e3cbf6b9abf0268359) Merge branch 'master' into eliza/update-resolver-docs ### 📊 Changes **4 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `client/src/lib.rs` (+1 -1) 📝 `resolver/README.md` (+3 -3) 📝 `resolver/src/lib.rs` (+1 -1) 📝 `resolver/src/lookup_ip.rs` (+1 -1) </details> ### 📄 Description This PR consists of two commits: the first updates the documentation for `trust-dns::Client` and `trust-dns-resolver` to no longer imply that `trust-dns-resolver` depends on `Client` (see https://github.com/runconduit/conduit/issues/711#issuecomment-385803754), and the second fixes a handful of other spelling and grammar errors I noticed while working on the first commit. Hopefully bundling these changes together in one PR is okay. Note that I didn't read _all_ the comments in TRust-DNS, so the second commit in this PR should definitely not be considered a complete editing pass; I just fixed the low-hanging fruit I had noticed while working in the codebase. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>