[PR #439] [MERGED] tokio related cleanups and preparations #1440

New issue

Closed

opened 2026-03-16 02:06:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:06:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/439
Author: @Keruspe
Created: 4/30/2018
Status: ✅ Merged
Merged: 5/1/2018
Merged by: @bluejekyll

Base: master ← Head: master

📝 Commits (2)

31385b5 move tokio-core to dependencies where applicable
b7e9976 server: add a mutex around handler in server_future

📊 Changes

11 files changed (+17 additions, -17 deletions)

View changed files

📝 native-tls/Cargo.toml (+3 -1)
📝 native-tls/src/lib.rs (+1 -0)
📝 openssl/Cargo.toml (+1 -1)
📝 openssl/src/lib.rs (+0 -1)
📝 proto/Cargo.toml (+1 -1)
📝 proto/src/lib.rs (+2 -1)
📝 proto/src/tcp/tcp_client_stream.rs (+0 -2)
📝 proto/src/tcp/tcp_stream.rs (+0 -2)
📝 rustls/Cargo.toml (+1 -1)
📝 rustls/src/lib.rs (+1 -0)
📝 server/src/server/server_future.rs (+7 -7)

📄 Description

Move tokio-core dependency to dev-dependencies for modules that now only use it in tests.
The remaining tokio_core::reactor::Core usage cannot be ported to tokio yet as there is no alternative to run() yet, tokio::run can only run Future<(), ()>, no return value or error. Some alternative should come in next release.
Prepare server_future for tokio-executor porting. With this, code compiles fine when porting to tokio-executor but we have the same execution context initialization we had for dns_future and I don't thing we want to introduce even more threading + tokio::run here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/439 **Author:** [@Keruspe](https://github.com/Keruspe) **Created:** 4/30/2018 **Status:** ✅ Merged **Merged:** 5/1/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`31385b5`](https://github.com/hickory-dns/hickory-dns/commit/31385b52d8f2b39f44668b65e9fe9de2ddb2d00a) move tokio-core to dependencies where applicable - [`b7e9976`](https://github.com/hickory-dns/hickory-dns/commit/b7e9976d7607fb7afe778dc5bcd7c5ab05e0fa6c) server: add a mutex around handler in server_future ### 📊 Changes **11 files changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `native-tls/Cargo.toml` (+3 -1) 📝 `native-tls/src/lib.rs` (+1 -0) 📝 `openssl/Cargo.toml` (+1 -1) 📝 `openssl/src/lib.rs` (+0 -1) 📝 `proto/Cargo.toml` (+1 -1) 📝 `proto/src/lib.rs` (+2 -1) 📝 `proto/src/tcp/tcp_client_stream.rs` (+0 -2) 📝 `proto/src/tcp/tcp_stream.rs` (+0 -2) 📝 `rustls/Cargo.toml` (+1 -1) 📝 `rustls/src/lib.rs` (+1 -0) 📝 `server/src/server/server_future.rs` (+7 -7) </details> ### 📄 Description Move tokio-core dependency to dev-dependencies for modules that now only use it in tests. The remaining tokio_core::reactor::Core usage cannot be ported to tokio yet as there is no alternative to run() yet, tokio::run can only run `Future<(), ()>`, no return value or error. Some alternative should come in next release. Prepare server_future for tokio-executor porting. With this, code compiles fine when porting to tokio-executor but we have the same execution context initialization we had for dns_future and I don't thing we want to introduce even more threading + tokio::run here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>