[PR #364] [MERGED] Factor out xfer #1390

New issue

Closed

opened 2026-03-16 02:03:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:03:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/364
Author: @bluejekyll
Created: 3/27/2018
Status: ✅ Merged
Merged: 3/28/2018
Merged by: @bluejekyll

Base: master ← Head: factor_out_xfer

📝 Commits (5)

4c51f98 refactor DnsFuture out of dns_handle
2c0f9cf Merge branch 'master' into support-mdns-sd
cc90a22 add doc for BasicDnsHandle::new
8191d0e update OpenSSL for Windows
d99f04a also fix 64 bit windows version

📊 Changes

8 files changed (+202 additions, -172 deletions)

View changed files

📝 appveyor.yml (+2 -2)
📝 proto/src/lib.rs (+5 -7)
📝 proto/src/tcp/tcp_client_stream.rs (+1 -1)
📝 proto/src/xfer/dns_future.rs (+9 -162)
➕ proto/src/xfer/dns_handle.rs (+169 -0)
➕ proto/src/xfer/mod.rs (+16 -0)
📝 proto/src/xfer/retry_dns_handle.rs (+0 -0)
📝 proto/src/xfer/secure_dns_handle.rs (+0 -0)

📄 Description

This moves the DnsHandle and DnsFuture components into an xfer module in the trust-dns-proto crate. These structs implement the fundamental DNS transfer protocol, i.e. actually passing messages back and forth over the IO streams.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/364 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 3/27/2018 **Status:** ✅ Merged **Merged:** 3/28/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `factor_out_xfer` --- ### 📝 Commits (5) - [`4c51f98`](https://github.com/hickory-dns/hickory-dns/commit/4c51f98f02435a9cba53b5c2863376a7bc914891) refactor DnsFuture out of dns_handle - [`2c0f9cf`](https://github.com/hickory-dns/hickory-dns/commit/2c0f9cf03b96c32de6d43b0f3225e3fe0ee246fa) Merge branch 'master' into support-mdns-sd - [`cc90a22`](https://github.com/hickory-dns/hickory-dns/commit/cc90a228e569122bdcdaf0ff1daa8a78f4a968a8) add doc for BasicDnsHandle::new - [`8191d0e`](https://github.com/hickory-dns/hickory-dns/commit/8191d0ea494a4e6497e3cb0a1e2c9d741fff3446) update OpenSSL for Windows - [`d99f04a`](https://github.com/hickory-dns/hickory-dns/commit/d99f04a926f74175fb945cfb50d62b25cbd7d730) also fix 64 bit windows version ### 📊 Changes **8 files changed** (+202 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `appveyor.yml` (+2 -2) 📝 `proto/src/lib.rs` (+5 -7) 📝 `proto/src/tcp/tcp_client_stream.rs` (+1 -1) 📝 `proto/src/xfer/dns_future.rs` (+9 -162) ➕ `proto/src/xfer/dns_handle.rs` (+169 -0) ➕ `proto/src/xfer/mod.rs` (+16 -0) 📝 `proto/src/xfer/retry_dns_handle.rs` (+0 -0) 📝 `proto/src/xfer/secure_dns_handle.rs` (+0 -0) </details> ### 📄 Description This moves the DnsHandle and DnsFuture components into an xfer module in the trust-dns-proto crate. These structs implement the fundamental DNS transfer protocol, i.e. actually passing messages back and forth over the IO streams. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>